[PATCH v2 Resent 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen
Miquel Raynal
miquel.raynal at bootlin.com
Wed Oct 18 23:31:51 PDT 2023
Hi Frank,
Frank.Li at nxp.com wrote on Wed, 18 Oct 2023 11:59:25 -0400:
> If IBIWON timeout happen, SDA line will always keep low because miss emit
> stop.
"
Upon IBIWON timeout, the SDA line will always be kept low if we don't
emit a stop. Calling svc_i3c_master_emit_stop() there will let the bus
return to idle state.
"
With this commit log,
Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>
>
> Call svc_i3c_master_emit_stop() to let i3c bus come back to idle statue
> when IBIWON timeout happen.
>
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Cc: stable at vger.kernel.org
> Signed-off-by: Frank Li <Frank.Li at nxp.com>
> ---
>
> Notes:
> Change from v1 to v2
> - Update commite message
>
> drivers/i3c/master/svc-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index b113460f059c3..1a57fdebaa26d 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -404,6 +404,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
> SVC_I3C_MSTATUS_IBIWON(val), 0, 1000);
> if (ret) {
> dev_err(master->dev, "Timeout when polling for IBIWON\n");
> + svc_i3c_master_emit_stop(master);
> goto reenable_ibis;
> }
>
Thanks,
Miquèl
More information about the linux-i3c
mailing list