[PATCH] i3c: master: Fix build error

Miquel Raynal miquel.raynal at bootlin.com
Fri Nov 17 03:22:15 PST 2023


Hi Jarkko,

jarkko.nikula at linux.intel.com wrote on Fri, 17 Nov 2023 13:09:24 +0200:

> Fix build error caused by commit 2aac0bf4ebc8 ("i3c: Add fallback method
> for GETMXDS CCC") which incorrectly access the "struct i3c_ccc_cmd_dest
> dest" as pointer.
> 
> drivers/i3c/master.c: In function ‘i3c_master_getmxds_locked’:
> drivers/i3c/master.c:1140:21: error: invalid type argument of ‘->’ (have ‘struct i3c_ccc_cmd_dest’)
>  1140 |                 dest->payload.len -= 3;
>       |                     ^~
> 
> Fixes: 2aac0bf4ebc8 ("i3c: Add fallback method for GETMXDS CCC")
> Signed-off-by: Jarkko Nikula <jarkko.nikula at linux.intel.com>

Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>

> ---
>  drivers/i3c/master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 718b643cb54d..8b729ebae2a6 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1135,7 +1135,7 @@ static int i3c_master_getmxds_locked(struct i3c_master_controller *master,
>  		 * Retry when the device does not support max read turnaround
>  		 * while expecting shorter length from this CCC command.
>  		 */
> -		dest->payload.len -= 3;
> +		dest.payload.len -= 3;
>  		ret = i3c_master_send_ccc_cmd_locked(master, &cmd);
>  		if (ret)
>  			goto out;


Thanks,
Miquèl



More information about the linux-i3c mailing list