[PATCH 1/5] i3c: dw: Create a generic fifo read function

Jeremy Kerr jk at codeconstruct.com.au
Thu Mar 30 19:16:01 PDT 2023


Hi Ben,

> > +static void dw_i3c_master_read_rx_fifo(struct dw_i3c_master *master,
> > +                                      u8 *bytes, int nbytes)
> > +{
> > +       return dw_i3c_master_read_fifo(master, RX_TX_DATA_PORT, bytes, nbytes);
> > +}
> > +
> 
> Might want to make it inline too.

The compiler will almost certainly work that out:

    $ arm-linux-gnueabihf-objdump -t drivers/i3c/master/dw-i3c-master.o | grep fifo
    00000b74 l     F .text	000000a4 dw_i3c_master_read_fifo

- and I'd prefer to not override any compiler decision not to inline, if
that works out better in specific circumstances or with any future
changes.

Cheers,


Jeremy



More information about the linux-i3c mailing list