[PATCH v2 3/3] i3c: ast2600: Add AST2600 platform-specific driver
Jeremy Kerr
jk at codeconstruct.com.au
Thu Mar 30 19:04:40 PDT 2023
Hi Ben,
Thanks for the review. Comments inline:
> How about wrapping the dw_i3c_master struct in an as2600_master struct
> and then you can use container of, and simply do sizeof(struct
> ast2600_master) ?
>
> Also removes the need below to set pdata at-all
Yep, sounds good, and avoids my quirky pointer arithmetic below that.
> > +static struct platform_driver ast2600_i3c_driver = {
> > + .probe = ast2600_i3c_probe,
> > + .remove = ast2600_i3c_remove,
> > + .driver = {
> > + .name = "ast2600-i3c-master",
> > + .of_match_table =
> > of_match_ptr(ast2600_i3c_master_of_match),
>
> given this is probably an of-device only, of_match_ptr not needed
> here?
Ack, will remove.
Thanks,
Jeremy
More information about the linux-i3c
mailing list