[PATCH 5/5] i3c: svc: Convert to platform remove callback returning void
Miquel Raynal
miquel.raynal at bootlin.com
Mon Mar 20 03:52:13 PDT 2023
Hi Uwe,
u.kleine-koenig at pengutronix.de wrote on Sun, 19 Mar 2023 00:33:11 +0100:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index e5476d04b403..e3f454123805 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1569,7 +1569,7 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int svc_i3c_master_remove(struct platform_device *pdev)
> +static void svc_i3c_master_remove(struct platform_device *pdev)
> {
> struct svc_i3c_master *master = platform_get_drvdata(pdev);
>
> @@ -1577,8 +1577,6 @@ static int svc_i3c_master_remove(struct platform_device *pdev)
>
> pm_runtime_dont_use_autosuspend(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> -
> - return 0;
> }
>
> static int __maybe_unused svc_i3c_runtime_suspend(struct device *dev)
> @@ -1616,7 +1614,7 @@ MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);
>
> static struct platform_driver svc_i3c_master = {
> .probe = svc_i3c_master_probe,
> - .remove = svc_i3c_master_remove,
> + .remove_new = svc_i3c_master_remove,
> .driver = {
> .name = "silvaco-i3c-master",
> .of_match_table = svc_i3c_master_of_match_tbl,
Thanks,
Miquèl
More information about the linux-i3c
mailing list