[PATCH 3/5] driver core: make struct device_type.uevent() take a const *

Greg Kroah-Hartman gregkh at linuxfoundation.org
Wed Jan 11 01:51:22 PST 2023


On Wed, Nov 23, 2022 at 01:38:05PM +0100, Rafael J. Wysocki wrote:
> On Wed, Nov 23, 2022 at 1:25 PM Greg Kroah-Hartman
> <gregkh at linuxfoundation.org> wrote:
> >
> > The uevent() callback in struct device_type should not be modifying the
> > device that is passed into it, so mark it as a const * and propagate the
> > function signature changes out into all relevant subsystems that use
> > this callback.
> >
> > Cc: Jens Axboe <axboe at kernel.dk>
> > Cc: "Rafael J. Wysocki" <rafael at kernel.org>
> > Cc: Len Brown <lenb at kernel.org>
> > Cc: Stefan Richter <stefanr at s5r6.in-berlin.de>
> > Cc: Wolfram Sang <wsa at kernel.org>
> > Cc: Alexandre Belloni <alexandre.belloni at bootlin.com>
> > Cc: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> > Cc: Sean Young <sean at mess.org>
> > Cc: Mauro Carvalho Chehab <mchehab at kernel.org>
> > Cc: Rob Herring <robh+dt at kernel.org>
> > Cc: Frank Rowand <frowand.list at gmail.com>
> > Cc: Maximilian Luz <luzmaximilian at gmail.com>
> > Cc: Hans de Goede <hdegoede at redhat.com>
> > Cc: Mark Gross <markgross at kernel.org>
> > Cc: Vinod Koul <vkoul at kernel.org>
> > Cc: Bard Liao <yung-chuan.liao at linux.intel.com>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> > Cc: Sanyog Kale <sanyog.r.kale at intel.com>
> > Cc: Andreas Noever <andreas.noever at gmail.com>
> > Cc: Michael Jamet <michael.jamet at intel.com>
> > Cc: Mika Westerberg <mika.westerberg at linux.intel.com>
> > Cc: Yehezkel Bernat <YehezkelShB at gmail.com>
> > Cc: Jiri Slaby <jirislaby at kernel.org>
> > Cc: Heikki Krogerus <heikki.krogerus at linux.intel.com>
> > Cc: "Matthew Wilcox (Oracle)" <willy at infradead.org>
> > Cc: "Martin K. Petersen" <martin.petersen at oracle.com>
> > Cc: Chaitanya Kulkarni <kch at nvidia.com>
> > Cc: Ming Lei <ming.lei at redhat.com>
> > Cc: Jilin Yuan <yuanjilin at cdjrlc.com>
> > Cc: Alan Stern <stern at rowland.harvard.edu>
> > Cc: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > Cc: Sakari Ailus <sakari.ailus at linux.intel.com>
> > Cc: Jason Gunthorpe <jgg at ziepe.ca>
> > Cc: Thomas Gleixner <tglx at linutronix.de>
> > Cc: Ira Weiny <ira.weiny at intel.com>
> > Cc: Dan Williams <dan.j.williams at intel.com>
> > Cc: Won Chung <wonchung at google.com>
> > Cc: alsa-devel at alsa-project.org
> > Cc: devicetree at vger.kernel.org
> > Cc: linux-acpi at vger.kernel.org
> > Cc: linux-block at vger.kernel.org
> > Cc: linux-i2c at vger.kernel.org
> > Cc: linux-i3c at lists.infradead.org
> > Cc: linux-input at vger.kernel.org
> > Cc: linux-kernel at vger.kernel.org
> > Cc: linux-media at vger.kernel.org
> > Cc: linux-serial at vger.kernel.org
> > Cc: linux-usb at vger.kernel.org
> > Cc: linux1394-devel at lists.sourceforge.net
> > Cc: platform-driver-x86 at vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> 
> (which my ACPI maintainer hat on).

thanks for the review, I'll add it to the v2 patch.

greg k-h



More information about the linux-i3c mailing list