From ben.dooks at sifive.com Fri Jul 8 09:49:48 2022 From: ben.dooks at sifive.com (Ben Dooks) Date: Fri, 8 Jul 2022 17:49:48 +0100 Subject: [PATCH] i3c: master; add error print for invalid node Message-ID: <20220708164948.268930-1-ben.dooks@sifive.com> Show an error if the OF code in the i3c master setup failed to read the register, so that if an incorrect node is supplied there is an error print to make it clear what the problem is Signed-off-by: Ben Dooks --- drivers/i3c/master.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 7850287dfe7a..271d687d0d07 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -2082,8 +2082,10 @@ static int of_i3c_master_add_dev(struct i3c_master_controller *master, return -EINVAL; ret = of_property_read_u32_array(node, "reg", reg, ARRAY_SIZE(reg)); - if (ret) + if (ret) { + dev_err(&master->dev, "i3c: invalid reg for %pOF\n", node); return ret; + } /* * The manufacturer ID can't be 0. If reg[1] == 0 that means we're -- 2.35.1