Feedback please: [PATCH] leds: New PCEngines Alix LED driver using gpio interface

Ed W lists at wildgooses.com
Thu Mar 17 13:59:06 EDT 2011


On 17/03/2011 17:52, Andres Salomon wrote:
> OLPC stuff lives in arch/x86/platform/olpc; if there was more
> alix-specific stuff, I'd suggest moving it into something similar.
> However, I didn't find any.  Maybe an arch/x86/platform/geode as a
> place to collect platform drivers for the various geode-based machines
> out there (alix, soekris, etc)?  Though honestly, I'm not that
> interested in doing the work to migrate stuff over to there.


As this is my first stab at this, I think you are agreeing that the
current change is ok as a first step at least?  (I can have a go at a
larger code re-org later...)

Can I get your final opinion on what should be in the code Copyright
statement before I resubmit with the module_init change? To recap I
don't want to alienate anyone, but the code is now based on a) leds-5501
and b) a patch from someone not currently credited in the file copyright
statement?  I have stated this origin in the commit log and noted the
derivation in the code itself. What to do..?

Thanks

Ed W



More information about the Linux-geode mailing list