[PATCH 1/2] cs5535-gpio: add AMD CS5535/CS5536 GPIO driver support
Andres Salomon
dilinger at collabora.co.uk
Thu Jun 11 11:16:10 EDT 2009
On Thu, 11 Jun 2009 16:46:35 +0200
Tobias Müller <Tobias_Mueller at twam.info> wrote:
> 2009/6/10 Andres Salomon <dilinger at collabora.co.uk>:
> > +config GPIO_CS5535
> > + tristate "AMD CS5535/CS5536 GPIO support"
> > + depends on PCI && !CS5535_GPIO && !MGEODE_LX
> > + help
> > + The AMD CS5535 and CS5536 southbridges support 28 GPIO
> > pins that
> > + can be used for quite a number of things. The CS5535/6
> > is found on
> > + AMD Geode and Lemote Yeeloong devices.
>
> Why do you depend on !MGEODE_LX? Are there any problems?
Because arch/x86/kernel/{mfgpt,geode}_32.c are built if
CONFIG_MGEODE_LX is set, and they will happily clobber each other. We
need to get a broken-out mfgpt driver completed, and then we can rework
or remove the arch/x86/kernel/{mfgpt,geode}_32.c stuff.
It's probably possible to add a separate config for that
(CONFIG_GEODE_LEGACY or something?) rather than having it depend upon
CONFIG_MGEODE_LX, but I haven't looked into it. I'd rather spend the
time fixing it correctly than fretting about with the various config
permutations. :)
More information about the Linux-geode
mailing list