<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On Monday 10 September 2012 07:31 PM,
Arnd Bergmann wrote:<br>
</div>
<blockquote cite="mid:201209101401.06859.arnd@arndb.de" type="cite">
<pre wrap="">On Monday 10 September 2012, Rajanikanth HV wrote:
</pre>
<blockquote type="cite">
<pre wrap="">+
+supplied-to:
+ This is a logical binding w.r.t power supply event change
+ across energy-management-module drivers where in the
+ runtime battery properties are shared along with uevent
+ notification.
+ ref: di->btemp_psy.external_power_changed =
+ ab8500_btemp_external_power_changed;
+ ab8500_btemp.c
+
+ Need for this property:
+ btemp, fg and charger updates power-supply properties
+ based on the events listed above.
+ Event handler invokes power supply change notifier
+ which in-turn invokes registered power supply class call-back
+ based on the 'supplied_to' string.
+ ref:
+ power_supply_changed_work(..) ./drivers/power/power_supply_core.c
+
+ example:
+ ab8500-btemp {
+ /* Other enery management module */
+ supplied-to = "ab8500_chargalg", "ab8500_fg";
+ num_supplicants = <2>;
+ };
+
</pre>
</blockquote>
<pre wrap="">
This looks like you're doing things the opposite way from everyone else.
Normally, each device uses phandles to refer to other objects it depends
on (gpio lines, regulators, clocks, interrupts, ...), rather than listing
things that depend on it.
Can you turn this around to be more like the others?</pre>
</blockquote>
We discussed about this on : "<span class="gI">13 July 2012 17:05",
pasting from that mail thread.<br>
==============</span><span class="gI">==============</span><br>
>> +Supplied-to:<br>
>> + This shall be power supply class dependency where in
the<br>
runtime battery<br>
>> + properties will be shared across fuel guage and
charging<br>
algorithm driver.<br>
><br>
> I <span class="il">probably</span> <span class="il">don</span>'<span
class="il">t</span> <span class="il">understand</span> <span
class="il">enough</span> of this, <span class="il">but</span> <span
class="il">shouldn</span>'<span class="il">t</span> the other<br>
devices<br>
> that are supplied by this have a reference to this node rather
than doing<br>
> it this way around? Why use strings here instead of phandles?<br>
<div class="im"><br>
This is a logical binding w.r.<span class="il">t</span> power
supply event change<br>
</div>
across energy-management-module drivers where in runtime battery<br>
properties are shared along with uevent notification.<br>
ref: di->btemp_psy.external_power_
<div id=":zd"><wbr>changed =<br>
ab8500_btemp_external_power_<wbr>changed;<br>
ref: ab8500_btemp.c<br>
<br>
Need for this property:<br>
<div class="im"> btemp, fg and charger updates power-supply
properties<br>
</div>
<div class="im"> based on the events listed above.<br>
</div>
<div class="im"> Event handler invokes power supply change
notifier<br>
</div>
<div class="im"> which in-turn invokes registered power supply
class call-back<br>
</div>
<div class="im"> based on the 'supplied_to' string.<br>
</div>
ref:<br>
power_supply_changed_work(..) ./drivers/power/power_supply_<wbr>core.c<br>
<br>
In this case how to approach through phandle?<br>
<span class="gI">==============</span><span class="gI">==============</span><br>
</div>
<br>
<blockquote cite="mid:201209101401.06859.arnd@arndb.de" type="cite">
<pre wrap="">
Note also that device tree identifiers should use '-' as a word separator,
not '_', and that a binding document should specify the exact set of
possible values. If the properties contain strings, please list every
valid string.
</pre>
<blockquote type="cite">
<pre wrap="">+ thermister-internal-to-battery = <1>;
+ li_ion_9100_battery = <0>;
</pre>
</blockquote>
<pre wrap="">
Boolean properties should be empty when enabled and not present when
disabled. In this example, one would just write
thermister-internal-to-battery;
Arnd
</pre>
</blockquote>
<br>
</body>
</html>