<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
于 2012年06月14日 14:44, Igor Grinberg 写道:
<blockquote cite="mid:4FD98856.8070601@compulab.co.il" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-unicode">
<pre wrap="">On 06/14/12 07:46, Zumeng Chen wrote:
</pre>
<blockquote type="cite" style="color: rgb(0, 0, 0);">
<pre wrap=""><span class="moz-txt-citetags">> </span>于 2012年06月13日 20:18, Hiremath, Vaibhav 写道:
</pre>
<blockquote type="cite" style="color: rgb(0, 0, 0);">
<pre wrap=""><span class="moz-txt-citetags">>> </span>On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote:
</pre>
<blockquote type="cite" style="color: rgb(0, 0, 0);">
<pre wrap=""><span class="moz-txt-citetags">>>> </span>From: Zumeng Chen<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:zumeng.chen@windriver.com"><zumeng.chen@windriver.com></a>
<span class="moz-txt-citetags">>>></span>
<span class="moz-txt-citetags">>>> </span>If we don't set proper debouce time for ads7846, then there are
<span class="moz-txt-citetags">>>> </span>flooded interrupt counters of ads7846 responding to one time
<span class="moz-txt-citetags">>>> </span>touch on screen, so the driver couldn't work well.
<span class="moz-txt-citetags">>>></span>
<span class="moz-txt-citetags">>>> </span>And since most OMAP3 series boards pass NULL pointer of board_pdata
<span class="moz-txt-citetags">>>> </span>to omap_ads7846_init, so it's more proper to set it in driver level
<span class="moz-txt-citetags">>>> </span>after having gpio_request done.
<span class="moz-txt-citetags">>>></span>
<span class="moz-txt-citetags">>>> </span>This patch has been validated on 3530evm.
<span class="moz-txt-citetags">>>></span>
<span class="moz-txt-citetags">>>> </span>Signed-off-by: Zumeng Chen<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:zumeng.chen@windriver.com"><zumeng.chen@windriver.com></a>
<span class="moz-txt-citetags">>>> </span>Signed-off-by: Syed Mohammed Khasim<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:khasim@ti.com"><khasim@ti.com></a>
<span class="moz-txt-citetags">>>> </span>---
<span class="moz-txt-citetags">>>> </span> drivers/input/touchscreen/ads7846.c | 4 ++++
<span class="moz-txt-citetags">>>> </span> 1 files changed, 4 insertions(+), 0 deletions(-)
<span class="moz-txt-citetags">>>></span>
<span class="moz-txt-citetags">>>> </span>diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
<span class="moz-txt-citetags">>>> </span>index f02028e..459ff29 100644
<span class="moz-txt-citetags">>>> </span>--- a/drivers/input/touchscreen/ads7846.c
<span class="moz-txt-citetags">>>> </span>+++ b/drivers/input/touchscreen/ads7846.c
<span class="moz-txt-citetags">>>> </span>@@ -980,6 +980,10 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784
<span class="moz-txt-citetags">>>> </span> }
<span class="moz-txt-citetags">>>></span>
<span class="moz-txt-citetags">>>> </span> ts->gpio_pendown = pdata->gpio_pendown;
<span class="moz-txt-citetags">>>> </span>+#ifdef CONFIG_ARCH_OMAP3
<span class="moz-txt-citetags">>>> </span>+ /* 310 means about 10 microsecond for omap3 */
<span class="moz-txt-citetags">>>> </span>+ gpio_set_debounce(pdata->gpio_pendown, 310);
<span class="moz-txt-citetags">>>> </span>+#endif
<span class="moz-txt-citetags">>>></span>
</pre>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">>> </span>Zumeng,
<span class="moz-txt-citetags">>></span>
<span class="moz-txt-citetags">>> </span>With my sign-off you are changing the original code, that too
<span class="moz-txt-citetags">>> </span>without my sign-off and ack.
<span class="moz-txt-citetags">>> </span>I wouldn't mind you to submit patches from my tree, but the expectation is
<span class="moz-txt-citetags">>> </span>if you are changing the original code, it should be under your sign-off.
</pre>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">> </span>Thanks, good to learn. I'll remove in next time.
</pre>
<blockquote type="cite" style="color: rgb(0, 0, 0);">
<pre wrap=""><span class="moz-txt-citetags">>> </span>Coming to the patch, #ifdef in driver is not recommended, and this 10msec
<span class="moz-txt-citetags">>> </span>delay is specific to OMAP GPIO and driver should not be aware of this,
<span class="moz-txt-citetags">>> </span>that's where you will find the original patch handling it in board file.
</pre>
</blockquote>
<pre wrap=""><span class="moz-txt-citetags">> </span>According to the git blame of the board-omap3evm.c I think
<span class="moz-txt-citetags">> </span>96974a24 did a good thing to all the related codes for omap3
<span class="moz-txt-citetags">> </span>boards. So I think we can call board and driver as BSP level <span class="moz-smiley-s1" title=":-)"><span>:-)</span></span>
<span class="moz-txt-citetags">> </span>
<span class="moz-txt-citetags">> </span>If #ifdef in driver can save many codes, I guess it's deserved.
</pre>
</blockquote>
<pre wrap="">No, platform/board specific ifdefs in the generic driver code are never
deserved.
How about the attached patch, does it fix the problem for you?
</pre>
</div>
</blockquote>
Sorry Igor, I just read your patch, yes, most are there, and we<br>
just have to set get_pendown_state as you early said. Really<br>
*thanks* for your drive :)<br>
<br>
Regards,<br>
Zumeng<br>
<blockquote cite="mid:4FD98856.8070601@compulab.co.il" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-unicode">
<pre wrap="">
<div class="moz-txt-sig">--
Regards,
Igor.
</div></pre>
</div>
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 16px;" lang="zh-CN">
<pre wrap="">
<fieldset class="mimeAttachmentHeader"><legend class="mimeAttachmentName">ads7846.patch</legend></fieldset>
diff --git a/arch/arm/mach-omap2/common-board-devices.c b/arch/arm/mach-omap2/common-board-devices.c
index 1706ebc..c187586 100644
--- a/arch/arm/mach-omap2/common-board-devices.c
+++ b/arch/arm/mach-omap2/common-board-devices.c
@@ -63,28 +63,30 @@ void __init omap_ads7846_init(int bus_num, int gpio_pendown, int gpio_debounce,
struct spi_board_info *spi_bi = &ads7846_spi_board_info;
int err;
- if (board_pdata && board_pdata->get_pendown_state) {
- err = gpio_request_one(gpio_pendown, GPIOF_IN, "TSPenDown");
- if (err) {
- pr_err("Couldn't obtain gpio for TSPenDown: %d\n", err);
- return;
- }
- gpio_export(gpio_pendown, 0);
-
- if (gpio_debounce)
- gpio_set_debounce(gpio_pendown, gpio_debounce);
+ err = gpio_request_one(gpio_pendown, GPIOF_IN, "TSPenDown");
+ if (err) {
+ pr_err("Couldn't obtain gpio for TSPenDown: %d\n", err);
+ return;
}
+ if (gpio_debounce)
+ gpio_set_debounce(gpio_pendown, gpio_debounce);
+
spi_bi->bus_num = bus_num;
spi_bi->irq = gpio_to_irq(gpio_pendown);
if (board_pdata) {
board_pdata->gpio_pendown = gpio_pendown;
spi_bi->platform_data = board_pdata;
+ if (board_pdata->get_pendown_state)
+ gpio_export(gpio_pendown, 0);
} else {
ads7846_config.gpio_pendown = gpio_pendown;
}
+ if (!board_pdata || (board_pdata && !board_pdata->get_pendown_state))
+ gpio_free(gpio_pendown);
+
spi_register_board_info(&ads7846_spi_board_info, 1);
}
#else
</pre>
</div>
</blockquote>
<br>
</body>
</html>