Hi Jon,<br><br>Many thanks for your quickly reply, please see my in-line reply<br><br><div class="gmail_quote">2012/6/11 Jon Hunter <span dir="ltr"><<a href="mailto:jon-hunter@ti.com" target="_blank">jon-hunter@ti.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im"><br>
<br>
On 06/11/2012 09:00 AM, Zumeng Chen wrote:<br>
> Signed-off-by: Vaibhav Hiremath <<a href="mailto:hvaibhav@ti.com">hvaibhav@ti.com</a>><br>
> Tested-by: Zumeng Chen <<a href="mailto:zumeng.chen@gmail.com">zumeng.chen@gmail.com</a>><br>
<br>
</div>I think that you need to have something in the changelog above, even if<br>
this is a trivial change.<br></blockquote><div>Yes, I'll add it in V2 <br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div><div class="h5"><br>
> ---<br>
> arch/arm/mach-omap2/board-omap3evm.c | 39 ++++++++++++++++++++++++++++++++++<br>
> 1 files changed, 39 insertions(+), 0 deletions(-)<br>
><br>
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c<br>
> index 639bd07..fef911d 100644<br>
> --- a/arch/arm/mach-omap2/board-omap3evm.c<br>
> +++ b/arch/arm/mach-omap2/board-omap3evm.c<br>
> @@ -24,6 +24,10 @@<br>
> #include <linux/leds.h><br>
> #include <linux/interrupt.h><br>
><br>
> +#include <linux/mtd/mtd.h><br>
> +#include <linux/mtd/partitions.h><br>
> +#include <linux/mtd/nand.h><br>
> +<br>
> #include <linux/spi/spi.h><br>
> #include <linux/spi/ads7846.h><br>
> #include <linux/i2c/twl.h><br>
> @@ -43,6 +47,7 @@<br>
><br>
> #include <plat/board.h><br>
> #include <plat/usb.h><br>
> +#include <plat/nand.h><br>
> #include "common.h"<br>
> #include <plat/mcspi.h><br>
> #include <video/omapdss.h><br>
> @@ -607,6 +612,37 @@ static struct regulator_consumer_supply dummy_supplies[] = {<br>
> REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),<br>
> };<br>
><br>
> +static struct mtd_partition omap3evm_nand_partitions[] = {<br>
> + /* All the partition sizes are listed in terms of NAND block size */<br>
> + {<br>
> + .name = "xloader-nand",<br>
<br>
</div></div>Is this the only non-volatile memory on the EVM? If so, you can probably<br>
drop the "-nand" part from the name. Also, if you look at other board<br>
files to be consistent in naming they use "X-Loader".<br></blockquote><div>As this kind usage, yes, the only memory. so I'll remove "nand" for all. <br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im"><br>
> + .offset = 0,<br>
> + .size = 4*(SZ_128K),<br>
> + .mask_flags = MTD_WRITEABLE<br>
> + },<br>
> + {<br>
> + .name = "uboot-nand",<br>
<br>
</div>"U-Boot"<br>
<div class="im"><br>
> + .offset = MTDPART_OFS_APPEND,<br>
> + .size = 14*(SZ_128K),<br>
> + .mask_flags = MTD_WRITEABLE<br>
> + },<br>
> + {<br>
> + .name = "params-nand",<br>
<br>
</div>"U-Boot Env"<br>
<div class="im"><br>
> + .offset = MTDPART_OFS_APPEND,<br>
> + .size = 2*(SZ_128K)<br>
> + },<br>
> + {<br>
> + .name = "linux-nand",<br>
<br>
</div>"Kernel"<br>
<div class="im"><br>
> + .offset = MTDPART_OFS_APPEND,<br>
> + .size = 40*(SZ_128K)<br>
> + },<br>
> + {<br>
> + .name = "jffs2-nand",<br>
<br>
</div>"File System"<br>
<div class="im">> + .size = MTDPART_SIZ_FULL,<br>
> + .offset = MTDPART_OFS_APPEND,<br>
> + },<br>
> +};<br>
> +<br>
> static void __init omap3_evm_init(void)<br>
> {<br>
> struct omap_board_mux *obm;<br>
> @@ -656,6 +692,9 @@ static void __init omap3_evm_init(void)<br>
> }<br>
> usb_musb_init(&musb_board_data);<br>
> usbhs_init(&usbhs_bdata);<br>
> + omap_nand_flash_init(NAND_BUSWIDTH_16, omap3evm_nand_partitions,<br>
> + ARRAY_SIZE(omap3evm_nand_partitions));<br>
> +<br>
> omap_ads7846_init(1, OMAP3_EVM_TS_GPIO, 310, NULL);<br>
> omap3evm_init_smsc911x();<br>
> omap3_evm_display_init();<br></div></blockquote><div>All fixed in V2.<br><br>Regards,<br>Zumeng <br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im">
<br>
</div>Cheers<br>
<span class="HOEnZb"><font color="#888888">Jon<br>
</font></span></blockquote></div><br>