[From nobody Mon May 23 06:44:22 2011 Return-Path: <linux-kernel-owner@vger.kernel.org> X-Original-To: broonie@opensource.wolfsonmicro.com Delivered-To: broonie@opensource.wolfsonmicro.com Received: from localhost (localhost [127.0.0.1]) by opensource2.wolfsonmicro.com (Postfix) with ESMTP id 3024D1B417F; Thu, 19 May 2011 23:04:38 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at opensource.wolfsonmicro.com Received: from opensource2.wolfsonmicro.com ([127.0.0.1]) by localhost (opensource.wolfsonmicro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Is7+yJTBawT9; Thu, 19 May 2011 23:04:37 +0100 (BST) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by opensource2.wolfsonmicro.com (Postfix) with ESMTP id B3FFB1B4168; Thu, 19 May 2011 23:04:36 +0100 (BST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935120Ab1ESWEH (ORCPT <rfc822;dp@opensource.wolfsonmicro.com> + 1 other); Thu, 19 May 2011 18:04:07 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:54897 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933084Ab1ESWEG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 19 May 2011 18:04:06 -0400 Received: from broonie by cassiel.sirena.org.uk with local (Exim 4.69) (envelope-from <broonie@sirena.org.uk>) id 1QNBK7-0007C2-Qv; Thu, 19 May 2011 23:04:03 +0100 Date: Thu, 19 May 2011 23:04:03 +0100 From: Mark Brown <broonie@opensource.wolfsonmicro.com> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>, Samuel Ortiz <sameo@linux.intel.com> Subject: Re: [PATCH] mfd wm8350: allocate irq descs dynamically Message-ID: <20110519220402.GA25452@sirena.org.uk> (sfid-20110519_230438_460880_F5FEF3A6) References: <20110519185648.GR30963@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110519185648.GR30963@pengutronix.de> X-Cookie: Do you have lysdexia? User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: <locally generated> X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Scanned: No (on cassiel.sirena.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-CRM114-Version: 20070810-BlameTheSegfault ( TRE 0.7.5 (LGPL) ) MR-D6DF1042 X-CRM114-CacheID: sfid-20110519_230438_460880_F5FEF3A6 X-CRM114-Status: GOOD ( 21.88 ) On Thu, May 19, 2011 at 08:56:48PM +0200, Sascha Hauer wrote: > + if (!pdata->irq_base) { > + wm8350->irq_base = irq_alloc_descs(-1, 0, ARRAY_SIZE(wm8350_irqs), 0); > + if (wm8350->irq_base < 0) { One other thing - it doesn't seem to be 100% desirable to making the allocation of the IRQ descriptors depend on not specifying a base - for many situations we're likely to want to know what the numbers we end up with are (eg, for passing to another device) but if we don't call irq_alloc_decs() the platform still has to arrange for the descriptors to be there in advance. It feels like the code should always use irq_alloc_descs(), though obviously that's not going to work right now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ]