[From nobody Mon May 23 06:44:22 2011 Return-Path: <linux-kernel-owner@vger.kernel.org> X-Original-To: broonie@opensource.wolfsonmicro.com Delivered-To: broonie@opensource.wolfsonmicro.com Received: from localhost (localhost [127.0.0.1]) by opensource2.wolfsonmicro.com (Postfix) with ESMTP id DF1101B4180; Thu, 19 May 2011 22:05:06 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at opensource.wolfsonmicro.com Received: from opensource2.wolfsonmicro.com ([127.0.0.1]) by localhost (opensource.wolfsonmicro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JyMmWJofnqEC; Thu, 19 May 2011 22:05:06 +0100 (BST) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by opensource2.wolfsonmicro.com (Postfix) with ESMTP id 8CD651B417F; Thu, 19 May 2011 22:05:05 +0100 (BST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932420Ab1ESVEk (ORCPT <rfc822;dp@opensource.wolfsonmicro.com> + 1 other); Thu, 19 May 2011 17:04:40 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:59872 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752177Ab1ESVEj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 19 May 2011 17:04:39 -0400 Received: from finisterre.wolfsonmicro.main (cpc1-sgyl4-0-0-cust394.sgyl.cable.virginmedia.com [80.192.23.139]) by opensource2.wolfsonmicro.com (Postfix) with ESMTPSA id 1172C1B417F; Thu, 19 May 2011 22:04:38 +0100 (BST) Received: from broonie by finisterre.wolfsonmicro.main with local (Exim 4.76) (envelope-from <broonie@opensource.wolfsonmicro.com>) id 1QNAOf-0004uI-I5; Thu, 19 May 2011 14:04:41 -0700 Date: Thu, 19 May 2011 14:04:41 -0700 From: Mark Brown <broonie@opensource.wolfsonmicro.com> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>, Samuel Ortiz <sameo@linux.intel.com> Subject: Re: [PATCH] mfd wm8350: allocate irq descs dynamically Message-ID: <20110519210440.GA18849@opensource.wolfsonmicro.com> (sfid-20110519_220507_189355_ADA1ADE4) References: <20110519185648.GR30963@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110519185648.GR30963@pengutronix.de> X-Cookie: You have no real enemies. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-CRM114-Version: 20070810-BlameTheSegfault ( TRE 0.7.5 (LGPL) ) MR-D6DF1042 X-CRM114-CacheID: sfid-20110519_220507_189355_ADA1ADE4 X-CRM114-Status: GOOD ( 12.52 ) On Thu, May 19, 2011 at 08:56:48PM +0200, Sascha Hauer wrote: > - if (!pdata || !pdata->irq_base) { > - dev_warn(wm8350->dev, "No interrupt support, no IRQ base\n"); > + if (!pdata) { > + dev_warn(wm8350->dev, "No interrupt support, no platform data\n"); This isn't terribly good, the only reason we're checking pdata here is because we can't dereference it to look up irq_base if it's not there. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ]