Hi Vishwanath,<div><br></div><div>Thanks. I will take it as a reference.</div><div><br></div><div>Yong<br><div><br><div class="gmail_quote">On Wed, Feb 9, 2011 at 11:52 AM, Vishwanath Sripathy <span dir="ltr"><<a href="mailto:vishwanath.sripathy@linaro.org">vishwanath.sripathy@linaro.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Yong,<br>
<div class="im"><br>
On Tue, Feb 8, 2011 at 9:21 PM, Yong Shen <<a href="mailto:yong.shen@linaro.org">yong.shen@linaro.org</a>> wrote:<br>
> Hi Arnaud,<br>
> I also took a while to think about this before posting patches. I prefer to<br>
> put it in board related code since the various PMIC used on each boards may<br>
> have influence on cpuidle latency or other charactors, although it could be<br>
> minor.<br>
</div>WHy don't you define cpuidle_latency table per board file and use the<br>
right one inside the common cpuidle driver. Then you can take care of<br>
board related latencies cleanly.<br>
<br>
Vishwa<br>
<div class="im">> Yong<br>
><br>
> On Tue, Feb 8, 2011 at 4:29 PM, Arnaud Patard <<a href="mailto:arnaud.patard@rtp-net.org">arnaud.patard@rtp-net.org</a>><br>
> wrote:<br>
>><br>
>> <a href="mailto:yong.shen@linaro.org">yong.shen@linaro.org</a> writes:<br>
>><br>
>> Hi,<br>
>><br>
>> > From: Yong Shen <<a href="mailto:yong.shen@freescale.com">yong.shen@freescale.com</a>><br>
>> ><br>
>> > Add cpuidle parameters to make cpuidle driver workable, but these<br>
>> > parameters need further tuning<br>
>> ><br>
>> > Signed-off-by: Yong Shen <<a href="mailto:yong.shen@freescale.com">yong.shen@freescale.com</a>><br>
>> > ---<br>
>> > arch/arm/mach-mx5/board-mx51_babbage.c | 114<br>
>> > ++++++++++++++++++++++++++++++++<br>
>> > arch/arm/mach-mx5/devices.c | 4 +<br>
>> > arch/arm/mach-mx5/devices.h | 1 +<br>
>> > 3 files changed, 119 insertions(+), 0 deletions(-)<br>
>><br>
>> I didn't look at how it's working nor did a review but from a very quick<br>
>> look, I'm wondering why it's in board-mx51_babbage.c. Can you explain to<br>
>> me what makes this code specific to babbage ?<br>
>><br>
>> Arnaud<br>
><br>
><br>
</div>> _______________________________________________<br>
> linaro-dev mailing list<br>
> <a href="mailto:linaro-dev@lists.linaro.org">linaro-dev@lists.linaro.org</a><br>
> <a href="http://lists.linaro.org/mailman/listinfo/linaro-dev" target="_blank">http://lists.linaro.org/mailman/listinfo/linaro-dev</a><br>
><br>
><br>
</blockquote></div><br></div></div>