<br>Hi Kevin,<br><div><br></div><div><br><div class="gmail_quote">On Wed, Dec 15, 2010 at 9:42 PM, Kevin Hilman <span dir="ltr"><<a href="mailto:khilman@deeprootsystems.com">khilman@deeprootsystems.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">"Govindraj.R" <<a href="mailto:govindraj.raja@ti.com">govindraj.raja@ti.com</a>> writes:<br>
<br>
> Changes invloves:<br>
> ----------------<br>
> 1) Addition of hwmod data for omap2/3/4.<br>
> 1) McSPI driver hwmod adaptation with cleanup of base address<br>
> macros and using omap-device API's.<br>
> 2) Runtime Conversion of McSPI driver<br>
><br>
</div><div class="im">> Changes from v1:<br>
> ---------------<br>
> 1) Fixing patch 5/5 comments for hwmod+runtime<br>
> Split the patch 5/5 to hwmod adaptation<br>
> and then runtime conversion<br>
> <a href="http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html" target="_blank">http://www.mail-archive.com/linux-omap@vger.kernel.org/msg33387.html</a><br>
><br>
> Testing Updates:<br>
> ----------------<br>
> Was tested using data transfer test module available at:<br>
> <a href="http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/" target="_blank">http://dev.omapzoom.org/?p=richo/device_driver_test.git;a=blob;f=mcspi/test_code/</a><br>
> utils/mcspi_modules/omap_mcspi_datatest.c;<br>
> h=e42ec10c5c844abdde6a7175a268b379fbbdb655;<br>
> hb=5d9a755d50e58de861c5e8991f2f607bc49b5dc3<br>
<br>
</div>Can you summarize what this test does?<br>
<br>
On what platforms was this tested?<br>
<br>
How was it tested for OMAP1 and OMAP2?<br></blockquote><div><br></div><div><br></div><div>Using the above mentioned test module we had done some</div><div>data transfer tests.</div><div>Platforms used used where :</div><div>
1) OMAP2430 SDP.</div><div>2) OMAP3 (ZOOM boards zoom2/3).</div><div>3) OMAP4430 SDP [ Here even basic Ethernet functionality was checked which is over SPI interface]</div><div>We boot tested on 2420/n800.</div><div><br>
</div>
<div>Coming to omap1,</div><div><br></div><div>This driver[omap2_mcspi.c] is applicable only from omap2_plus</div><div>for omap1 omap_uwire.c is the spi driver file.</div><div><br></div><div>Looking into the driver/spi/Kconfig and Makefile:</div>
<div><br></div><div><KCONFIG SNIP></div><div><br></div><div><div>config SPI_OMAP_UWIRE</div><div> tristate "OMAP1 MicroWire"</div><div> depends on ARCH_OMAP1</div></div><div><br></div><div><div>
config SPI_OMAP24XX</div><div> tristate "McSPI driver for OMAP"</div><div> depends on ARCH_OMAP2PLUS</div></div><div><br></div><div><MAKEFILE SNIP></div><div><br></div><div>obj-$(CONFIG_SPI_OMAP_UWIRE) += omap_uwire.o</div>
<div><div>obj-$(CONFIG_SPI_OMAP24XX) += omap2_mcspi.o</div></div><div><br></div><div><br></div><div>---</div><div>Thanks,</div><div>Govindraj.R</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<font color="#888888"><br>
Kevin<br>
</font><div><div></div><div class="h5"><br>
> System wide suspend and ret/off counts observation,<br>
> ensured that no behavioral difference with and without<br>
> this patch series.<br>
><br>
> Benoit Cousson (1):<br>
> OMAP4: hwmod data: Add McSPI<br>
><br>
> Charulatha V (5):<br>
> OMAP2420: hwmod data: Add McSPI<br>
> OMAP2430: hwmod data: Add McSPI<br>
> OMAP3: hwmod data: Add McSPI<br>
> OMAP3: clocks: Update clock domain name for mcspi fck<br>
> OMAP: devices: Modify McSPI device to adapt to hwmod framework<br>
><br>
> Govindraj.R (1):<br>
> OMAP: runtime: McSPI driver runtime conversion<br>
><br>
> arch/arm/mach-omap2/clock3xxx_data.c | 4 +<br>
> arch/arm/mach-omap2/devices.c | 189 ++++---------------<br>
> arch/arm/mach-omap2/omap_hwmod_2420_data.c | 156 ++++++++++++++++<br>
> arch/arm/mach-omap2/omap_hwmod_2430_data.c | 219 ++++++++++++++++++++++<br>
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 280 ++++++++++++++++++++++++++++<br>
> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 267 ++++++++++++++++++++++++++<br>
> arch/arm/plat-omap/include/plat/mcspi.h | 11 +<br>
> drivers/spi/omap2_mcspi.c | 225 +++++++---------------<br>
> 8 files changed, 1051 insertions(+), 300 deletions(-)<br>
><br>
><br>
> --<br>
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in<br>
> the body of a message to <a href="mailto:majordomo@vger.kernel.org">majordomo@vger.kernel.org</a><br>
> More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html" target="_blank">http://vger.kernel.org/majordomo-info.html</a><br>
</div></div></blockquote></div><br><br>
</div>