<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=utf-8">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<title>Re: [PATCH] ARM: imx: Add mx53 changes to crm_regs</title>
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=WordSection1>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Hi Fabio,<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Fabio Estevam
[mailto:festevam@gmail.com] <br>
<b>Sent:</b> Monday, November 29, 2010 6:11 PM<br>
<b>To:</b> Nguyen Dinh-R00091<br>
<b>Cc:</b> linux-kernel@vger.kernel.org; amit.kucheria@canonical.com;
linux@arm.linux.org.uk; s.hauer@pengutronix.de; eric@eukrea.com;
u.kleine-koenig@pengutronix.de; linux-arm-kernel@lists.infradead.org<br>
<b>Subject:</b> Re: [PATCH] ARM: imx: Add mx53 changes to crm_regs<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p style='margin-bottom:12.0pt'><span style='font-size:10.0pt'>Hi Dinh,<br>
<br>
On Mon, Nov 29, 2010 at 8:54 PM, <Dinh.Nguyen@freescale.com> wrote:<br>
...<br>
><br>
> /* eSDHC */<br>
> -CLK_GET_RATE(esdhc1, 1, ESDHC1_MSHC1)<br>
> -CLK_SET_PARENT(esdhc1, 1, ESDHC1_MSHC1)<br>
> -CLK_SET_RATE(esdhc1, 1, ESDHC1_MSHC1)<br>
> +CLK_GET_RATE(esdhc1, 1, ESDHC1_MSHC2)<br>
> +CLK_SET_PARENT(esdhc1, 1, ESDHC1_MSHC2)<br>
> +CLK_SET_RATE(esdhc1, 1, ESDHC1_MSHC2)<br>
><br>
> -CLK_GET_RATE(esdhc2, 1, ESDHC2_MSHC2)<br>
> -CLK_SET_PARENT(esdhc2, 1, ESDHC2_MSHC2)<br>
> -CLK_SET_RATE(esdhc2, 1, ESDHC2_MSHC2)<br>
> +CLK_GET_RATE(esdhc2, 1, ESDHC2_3_MSHC2)<br>
> +CLK_SET_PARENT(esdhc2, 1, ESDHC2_3_MSHC2)<br>
> +CLK_SET_RATE(esdhc2, 1, ESDHC2_3_MSHC2)<br>
<br>
Shouldn´t this be part of another patch?<span style='color:#1F497D'><o:p></o:p></span></span></p>
<p style='margin-bottom:12.0pt'><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>I needed these changes because the patch would break the build
if these changes are made? Are you referring to the change from ESDHC1_MSHC1
-> ESDHC1_MSHC2, or ESDHC2_MSHC2 -> ESDCH2_3_MSHC2? <o:p></o:p></span></p>
<p style='margin-bottom:12.0pt'><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>For the case of ESDHC1_MSHC1 -> ESDHC1_MSHC2, it just a
matter of semantics fix(there is no MSHC1 in MX51 or MX53). But for the ESDHC2_MSHC2
-> ESDCH2_3_MSHC2 change, its because for MX53, ESDHC2(which was getting the
clocks from the PLLs and feeding them to ESDHC3) is now reversed(ESDHC3 is
getting clocks from the PLL and feeding it to ESDHC2). <o:p></o:p></span></p>
<p style='margin-bottom:12.0pt'><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Dinh<o:p></o:p></span></p>
<p style='margin-bottom:12.0pt'><span style='font-size:10.0pt'><br>
<br>
Regards,<br>
<br>
Fabio Estevam</span><o:p></o:p></p>
</div>
</body>
</html>