<br><br><div class="gmail_quote">2010/10/21 Baruch Siach <span dir="ltr"><<a href="mailto:baruch@tkos.co.il">baruch@tkos.co.il</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi xiao,<br>
<div class="im"><br>
On Thu, Oct 21, 2010 at 10:08:02AM +0800, xiao jiang wrote:<br>
> 2010/10/21 xiao jiang <<a href="mailto:jgq516@gmail.com">jgq516@gmail.com</a>><br>
</div><div class="im">> > 2010/10/20 Baruch Siach <<a href="mailto:baruch@tkos.co.il">baruch@tkos.co.il</a>><br>
</div><div><div></div><div class="h5">> >> On Wed, Oct 20, 2010 at 05:34:43PM +0800, <a href="mailto:jgq516@gmail.com">jgq516@gmail.com</a> wrote:<br>
> >> > From: Xiao Jiang <<a href="mailto:jgq516@gmail.com">jgq516@gmail.com</a>><br>
> >> ><br>
> >> > Enable debug board support for mx35pdk. As suggested<br>
> >> > by Fabio, add MXC_DEBUG_BOARD config and redefinition<br>
> >> > EXPIO_PARENT_INT.<br>
> >> ><br>
> >> > Signed-off-by: Xiao Jiang <<a href="mailto:jgq516@gmail.com">jgq516@gmail.com</a>><br>
> >> > Signed-off-by: Fabio Estevam <<a href="mailto:fabio.estevam@freescale.com">fabio.estevam@freescale.com</a>><br>
> >> > ---<br>
> >> > arch/arm/mach-mx3/Kconfig | 1 +<br>
> >> > arch/arm/mach-mx3/mach-mx35_3ds.c | 8 ++++++++<br>
> >> > 2 files changed, 9 insertions(+), 0 deletions(-)<br>
> >> ><br>
> >> > diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig<br>
> >> > index 85beece..cdf6ac5 100644<br>
> >> > --- a/arch/arm/mach-mx3/Kconfig<br>
> >> > +++ b/arch/arm/mach-mx3/Kconfig<br>
> >><br>
> >> [snip]<br>
> >><br>
> >> > @@ -95,6 +99,10 @@ static void __init mxc_board_init(void)<br>
> >> > imx35_add_imx_uart0(&uart_pdata);<br>
> >> ><br>
> >> > mxc_register_device(&mxc_otg_udc_device, &usb_pdata);<br>
> >> > +<br>
> >> > + if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT))<br>
> >> > + pr_warn("Init of the debugboard failed, all "<br>
> >> > + "devices on the board are unusable.\n");<br>
> >> ^^^^^<br>
> >> You probably mean debugboard here. I'd change the wording.<br>
> >><br>
> >> There are some devices in the debug board, such as lan9217 ethernet. If<br>
> > mxc_expio_init failed,<br>
> > then the lan9217 can't be use.<br>
<br>
</div></div>Of course. But this does not make devices on the main board unusable, isn't<br>
it? The user might think that his whole system is unusable because of this<br>
init failure.<br>
<div class="im"><br></div></blockquote><div>Ok, no relation with main board, to avoid confuse, maybe "all devices on the <b>debug</b> board are unusable" is more make sense, is it ok?<br><br>Thanks,<br>Xiao Jiang<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
> > BTW: In mach-mx5/board-mx51_3ds.c and mach-mx31_3ds.c, the warn messages<br>
> > are same.<br>
> > if (mxc_expio_init(MX51_CS5_BASE_ADDR,<br>
> > EXPIO_PARENT_INT))<br>
> ><br>
> > printk(KERN_WARNING "Init of the debugboard failed, all "<br>
> ><br>
> > "devices on the board are<br>
> > unusable.\n");<br>
> ><br>
> > Ooo, I pressed the keyboard neglectfully[?], and you can see below<br>
> sentence in mach-mx31_3ds.c.<br>
> if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT))<br>
> printk(KERN_WARNING "Init of the debugboard failed, all "<br>
> "devices on the board are unusable.\n");<br>
<br>
</div>Then this wording should also change there. Adding Jason Wang to Cc.<br>
<br>
baruch<br>
<br>
> Thanks,<br>
> Xiao Jiang<br>
<font color="#888888"><br>
--<br>
</font><div><div></div><div class="h5"> ~. .~ Tk Open Systems<br>
=}------------------------------------------------ooO--U--Ooo------------{=<br>
- <a href="mailto:baruch@tkos.co.il">baruch@tkos.co.il</a> - tel: +972.2.679.5364, <a href="http://www.tkos.co.il" target="_blank">http://www.tkos.co.il</a> -<br>
</div></div></blockquote></div><br>