Hi amit,<br><br><div class="gmail_quote">On Mon, Oct 18, 2010 at 6:02 PM, Amit Kucheria <span dir="ltr"><<a href="mailto:amit.kucheria@linaro.org">amit.kucheria@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Yong,<br>
<br>
I get the following errors if I try to compile this with the Linaro toolchain.<br>
<br>
In file included from<br>
/home/amit/work/sources/linux-amit-upstream.git/arch/arm/plat-mxc/include/mach/hardware.h:63:0,<br>
from<br>
/home/amit/work/sources/linux-amit-upstream.git/arch/arm/plat-mxc/devices/platform-fec.c:10:<br>
/home/amit/work/sources/linux-amit-upstream.git/arch/arm/plat-mxc/include/mach/mxc.h:139:2:<br>
error: expected specifier-qualifier-list before ‘u32’<br>
<br>
Perhap following patch is required?<br>
<br>
diff --git a/arch/arm/plat-mxc/include/mach/hardware.h<br>
b/arch/arm/plat-mxc/include/mach/hardware.h<br>
index ebadf4a..c9587fd 100644<br>
--- a/arch/arm/plat-mxc/include/mach/hardware.h<br>
+++ b/arch/arm/plat-mxc/include/mach/hardware.h<br>
@@ -21,6 +21,7 @@<br>
#define __ASM_ARCH_MXC_HARDWARE_H__<br>
<br>
#include <asm/sizes.h><br>
+#include <asm/types.h><br></blockquote><div>Although I did not meet this problem, I also think it is an issue. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
> + u32 pll_reg;<br>
> + u32 pll_rate;<br>
> + u32 cpu_rate;<br>
> + u32 pdr0_reg;<br>
> + u32 pdf;<br>
> + u32 mfi;<br>
> + u32 mfd;<br>
> + u32 mfn;<br>
> + u32 cpu_voltage;<br>
> + u32 cpu_podf;<br>
> +};<br>
> +<br>
<br>
</div>Get rid of all members of struct cpu_op except cpu_rate for now. We can<br>
re-add it later.<br>
<br>
Also, I wonder if this struct and the external declaration should be moved<br>
out to plat/mxc_cpufreq.h<br></blockquote><div>Maybe to mach/mxc.h which is the place for keeping platform related definitions.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div></div><div class="h5"><br>
> +extern struct cpu_op *(*get_cpu_op)(int *op);<br>
> +#endif<br>
> +<br>
> #if defined(CONFIG_ARCH_MX3) || defined(CONFIG_ARCH_MX2)<br>
> /* These are deprecated, use mx[23][157]_setup_weimcs instead. */<br>
> #define CSCR_U(n) (IO_ADDRESS(WEIM_BASE_ADDR + n * 0x10))<br>
> --<br>
> 1.6.3.3<br>
</div></div></blockquote></div><br>