Hi Fabio,<br><br><div class="gmail_quote">2010/10/19 Fabio Estevam <span dir="ltr"><<a href="mailto:festevam@gmail.com">festevam@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Xiao,<br>
<br>
2010/10/18 xiao jiang <<a href="mailto:jgq516@gmail.com">jgq516@gmail.com</a>>:<br>
<div class="im">> Hi Uwe & Fabio,<br>
><br>
> 2010/10/15 <<a href="mailto:jgq516@gmail.com">jgq516@gmail.com</a>><br>
>><br>
>> From: Xiao Jiang <<a href="mailto:jgq516@gmail.com">jgq516@gmail.com</a>><br>
>><br>
>> Add debug board support, then kernel can boot from lan9217 ethernet.<br>
>><br>
>> Signed-off-by: Xiao Jiang <<a href="mailto:jgq516@gmail.com">jgq516@gmail.com</a>><br>
>> ---<br>
>> arch/arm/mach-mx3/mach-mx35_3ds.c | 9 +++++++++<br>
>> arch/arm/plat-mxc/include/mach/iomux-mx3.h | 4 ++++<br>
>> 2 files changed, 13 insertions(+), 0 deletions(-)<br>
>><br>
>> diff --git a/arch/arm/mach-mx3/mach-mx35_3ds.c<br>
>> b/arch/arm/mach-mx3/mach-mx35_3ds.c<br>
>> index 1c30d72..78e0657 100644<br>
>> --- a/arch/arm/mach-mx3/mach-mx35_3ds.c<br>
>> +++ b/arch/arm/mach-mx3/mach-mx35_3ds.c<br>
>> @@ -34,11 +34,16 @@<br>
>><br>
>> #include <mach/hardware.h><br>
>> #include <mach/common.h><br>
>> +#include <mach/irqs.h><br>
>> +#include <mach/iomux-mx3.h><br>
<br>
</div>You don't need to add this.<br>
<div class="im"><br>
>> #include <mach/iomux-mx35.h><br>
>> +#include <mach/3ds_debugboard.h><br>
>><br>
>> #include "devices-imx35.h"<br>
>> #include "devices.h"<br>
>><br>
>> +#define EXPIO_PARENT_INT IOMUX_TO_IRQ(MX35_PIN_GPIO1_1)<br>
<br>
</div>Why don't you use MX35_PAD_GPIO1_1__GPIO1_1 instead which is already defined at:<br>
arch/arm/plat-mxc/include/mach/iomux-mx35.h ?<br>
<br>
<br></blockquote><div>I tried to use MX35_PAD_GPIO1_1__GPIO1_1, but there isn't function to transform to irq num, so I added<br>the pin definition in iomux-mx3.h. Is there any function can transform the PAD to irq num?<br>
<br>Only board-mx51_3ds.c & mach-mx31_3ds.c which called mxc_expio_init function, and I followed the rule of mach-mx31_3ds.c. Is it ok to change style like mx51_3ds as follows?<br>#define EXPIO_PARENT_INT (MXC_INTERNAL_IRQS + GPIO_PORTA + 6)<br>
<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Also, look at how MX31-3stack implemented the debug board support and<br>
pass MXC_DEBUG_BOARD in the Kconfig.<br>
<div class="im"><br></div></blockquote><div>Got it, will add it <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
><br>
> Any comments? And I can't the sdma driver in arch/arm/plat-mxc/ which is<br>
> used by lots of <a href="http://i.mx" target="_blank">i.mx</a> chips, is somebody planing to do it or<br>
> it will going to mainline soon ?<br>
<br>
</div>Sascha submitted initial support patches for i.MX SDMA.<br>
<br></blockquote><div>That is great! <br><br>Thanks <br>Xiao Jiang<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Regards,<br>
<font color="#888888"><br>
Fabio Estevam<br>
</font></blockquote></div><br>