<div>Hi,</div>
<div>Thank you for your interesting.<br><br></div>
<div class="gmail_quote">On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <span dir="ltr"><<a href="mailto:kmpark@infradead.org">kmpark@infradead.org</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Hi,<br><br>Looks good to me except minor fixup.<br><br>Acked-by: Kyungmin Park <<a href="mailto:kyungmin.park@samsung.com">kyungmin.park@samsung.com</a>><br>
<div>
<div></div>
<div class="h5"><br>On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi <<a href="mailto:chlrbgh0@gmail.com">chlrbgh0@gmail.com</a>> wrote:<br>> This patch adds to support Torbreck board of aESOP community using<br>> Samsung S5PV210 SoC.<br>
><br>> Signed-off-by: Kyuho Choi <<a href="mailto:chlrbgh0@gmail.com">chlrbgh0@gmail.com</a>><br>> Signed-off-by: Hyunchul Ko <<a href="mailto:ghcstop@gmail.com">ghcstop@gmail.com</a>><br>> ---<br>
> arch/arm/mach-s5pv210/Kconfig | 18 +++++<br>> arch/arm/mach-s5pv210/Makefile | 1 +<br>> arch/arm/mach-s5pv210/mach-torbreck.c | 133 +++++++++++++++++++++++++++++++++<br>> 3 files changed, 152 insertions(+), 0 deletions(-)<br>
> create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c<br>><br>> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig<br>> index d3a3895..c5ec466 100644<br>> --- a/arch/arm/mach-s5pv210/Kconfig<br>
> +++ b/arch/arm/mach-s5pv210/Kconfig<br>> @@ -139,6 +139,24 @@ config MACH_SMDKV210<br>> help<br>> Machine support for Samsung SMDKV210<br>><br>> +config MACH_TORBRECK<br>> + bool "Torbreck"<br>
> + select CPU_S5PV210<br>> + select ARCH_SPARSEMEM_ENABLE<br>> + select S3C_DEV_HSMMC<br>> + select S3C_DEV_HSMMC1<br>> + select S3C_DEV_HSMMC2<br>> + select S3C_DEV_HSMMC3<br>
> + select S3C_DEV_I2C1<br>> + select S3C_DEV_I2C2<br>> + select S3C_DEV_RTC<br>> + select S3C_DEV_WDT<br>> + select S5PV210_SETUP_I2C1<br>> + select S5PV210_SETUP_I2C2<br>
> + select S5PV210_SETUP_SDHCI<br>> + help<br>> + Machine support for aESOP Torbreck<br></div></div>Just question. Does it TDROID board?<br></blockquote>
<div> </div>
<div>No, Torbreck is aESOP community's co-work board. It's not TDORID.</div>
<div> </div>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">
<div>
<div></div>
<div class="h5">> +<br>> endmenu<br>><br>> endif<br>> diff --git a/arch/arm/mach-s5pv210/Makefile b/arch/arm/mach-s5pv210/Makefile<br>> index 05048c5..927c2b7 100644<br>> --- a/arch/arm/mach-s5pv210/Makefile<br>
> +++ b/arch/arm/mach-s5pv210/Makefile<br>> @@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA) += mach-aquila.o<br>> obj-$(CONFIG_MACH_SMDKV210) += mach-smdkv210.o<br>> obj-$(CONFIG_MACH_SMDKC110) += mach-smdkc110.o<br>
> obj-$(CONFIG_MACH_GONI) += mach-goni.o<br>> +obj-$(CONFIG_MACH_TORBRECK) += mach-torbreck.o<br>><br>> # device support<br>><br>> diff --git a/arch/arm/mach-s5pv210/mach-torbreck.c b/arch/arm/mach-s5pv210/mach-torbreck.c<br>
> new file mode 100644<br>> index 0000000..3142250<br>> --- /dev/null<br>> +++ b/arch/arm/mach-s5pv210/mach-torbreck.c<br>> @@ -0,0 +1,133 @@<br>> +/* linux/arch/arm/mach-s5pv210/mach-torbreck.c<br>> + *<br>
> + * Copyright (c) 2010 aESOP Community<br>> + * <a href="http://www.aesop.or.kr/" target="_blank">http://www.aesop.or.kr/</a><br>> + *<br>> + * This program is free software; you can redistribute it and/or modify<br>
> + * it under the terms of the GNU General Public License version 2 as<br>> + * published by the Free Software Foundation.<br>> +*/<br>> +<br>> +#include <linux/kernel.h><br>> +#include <linux/types.h><br>
> +#include <linux/i2c.h><br>> +#include <linux/init.h><br>> +#include <linux/serial_core.h><br>> +<br>> +#include <asm/mach/arch.h><br>> +#include <asm/mach/map.h><br>> +#include <asm/setup.h><br>
> +#include <asm/mach-types.h><br>> +<br>> +#include <mach/map.h><br>> +#include <mach/regs-clock.h><br>> +<br>> +#include <plat/regs-serial.h><br>> +#include <plat/s5pv210.h><br>
> +#include <plat/devs.h><br>> +#include <plat/cpu.h><br>> +#include <plat/iic.h><br>> +<br>> +/* Following are default values for UCON, ULCON and UFCON UART registers */<br>> +#define TORBRECK_UCON_DEFAULT (S3C2410_UCON_TXILEVEL | \<br>
> + S3C2410_UCON_RXILEVEL | \<br>> + S3C2410_UCON_TXIRQMODE | \<br>> + S3C2410_UCON_RXIRQMODE | \<br>
> + S3C2410_UCON_RXFIFO_TOI | \<br>> + S3C2443_UCON_RXERR_IRQEN)<br>> +<br>> +#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8<br>> +<br>> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | \<br>
> + S5PV210_UFCON_TXTRIG4 | \<br>> + S5PV210_UFCON_RXTRIG4)<br><br></div></div>Any reason to use TRIG4? just use the full trigger e.g., 256.<br></blockquote>
<div> </div>
<div>Okay, I'll fix it.</div>
<div> </div>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">
<div class="im">> +<br>> +static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {<br>> + [0] = {<br>> + .hwport = 0,<br>> + .flags = 0,<br></div>
There's no code for flags, please remove it all.<br></blockquote>
<div> </div>
<div>Okay, I'll remove it.</div>
<div> </div>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">> + .ucon = TORBRECK_UCON_DEFAULT,<br>
<div>
<div></div>
<div class="h5">> + .ulcon = TORBRECK_ULCON_DEFAULT,<br>> + .ufcon = TORBRECK_UFCON_DEFAULT,<br>> + },<br>> + [1] = {<br>> + .hwport = 1,<br>
> + .flags = 0,<br>> + .ucon = TORBRECK_UCON_DEFAULT,<br>> + .ulcon = TORBRECK_ULCON_DEFAULT,<br>> + .ufcon = TORBRECK_UFCON_DEFAULT,<br>
> + },<br>> + [2] = {<br>> + .hwport = 2,<br>> + .flags = 0,<br>> + .ucon = TORBRECK_UCON_DEFAULT,<br>> + .ulcon = TORBRECK_ULCON_DEFAULT,<br>
> + .ufcon = TORBRECK_UFCON_DEFAULT,<br>> + },<br>> + [3] = {<br>> + .hwport = 3,<br>> + .flags = 0,<br>> + .ucon = TORBRECK_UCON_DEFAULT,<br>
> + .ulcon = TORBRECK_ULCON_DEFAULT,<br>> + .ufcon = TORBRECK_UFCON_DEFAULT,<br>> + },<br>> +};<br>> +<br>> +static struct platform_device *torbreck_devices[] __initdata = {<br>
> + &s5pv210_device_iis0,<br>> + &s3c_device_cfcon,<br>> + &s3c_device_hsmmc0,<br>> + &s3c_device_hsmmc1,<br>> + &s3c_device_hsmmc2,<br>> + &s3c_device_hsmmc3,<br>
> + &s3c_device_i2c0,<br>> + &s3c_device_i2c1,<br>> + &s3c_device_i2c2,<br>> + &s3c_device_rtc,<br>> + &s3c_device_wdt,<br>> +};<br>> +<br>> +static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {<br>
> + /* To Be Updated */<br>> +};<br>> +<br>> +static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {<br>> + /* To Be Updated */<br>> +};<br>> +<br>> +static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {<br>
> + /* To Be Updated */<br>> +};<br>> +<br>> +static void __init torbreck_map_io(void)<br>> +{<br>> + s5p_init_io(NULL, 0, S5P_VA_CHIPID);<br>> + s3c24xx_init_clocks(24000000);<br>> + s3c24xx_init_uarts(torbreck_uartcfgs, ARRAY_SIZE(torbreck_uartcfgs));<br>
> +}<br>> +<br>> +static void __init torbreck_machine_init(void)<br>> +{<br>> + s3c_i2c0_set_platdata(NULL);<br>> + s3c_i2c1_set_platdata(NULL);<br>> + s3c_i2c2_set_platdata(NULL);<br>
> + i2c_register_board_info(0, torbreck_i2c_devs0,<br>> + ARRAY_SIZE(torbreck_i2c_devs0));<br>> + i2c_register_board_info(1, torbreck_i2c_devs1,<br>> + ARRAY_SIZE(torbreck_i2c_devs1));<br>
> + i2c_register_board_info(2, torbreck_i2c_devs2,<br>> + ARRAY_SIZE(torbreck_i2c_devs2));<br>> +<br>> + platform_add_devices(torbreck_devices, ARRAY_SIZE(torbreck_devices));<br>
> +}<br>> +<br>> +MACHINE_START(TORBRECK, "TORBRECK")<br>> + /* Maintainer: Hyunchul Ko <<a href="mailto:ghcstop@gmail.com">ghcstop@gmail.com</a>> */<br>> + .phys_io = S3C_PA_UART & 0xfff00000,<br>
> + .io_pg_offst = (((u32)S3C_VA_UART) >> 18) & 0xfffc,<br>> + .boot_params = S5P_PA_SDRAM + 0x100,<br>> + .init_irq = s5pv210_init_irq,<br>> + .map_io = torbreck_map_io,<br>
> + .init_machine = torbreck_machine_init,<br>> + .timer = &s3c24xx_timer,<br>> +MACHINE_END<br>> --<br>> 1.5.6.3<br>><br></div></div>> --<br>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in<br>
> the body of a message to <a href="mailto:majordomo@vger.kernel.org">majordomo@vger.kernel.org</a><br>> More majordomo info at <a href="http://vger.kernel.org/majordomo-info.html" target="_blank">http://vger.kernel.org/majordomo-info.html</a><br>
><br></blockquote></div>
<div><br>Thanks,</div>
<div>Kyuho Choi</div>