<br><br><div class="gmail_quote">2010/8/18 Daniel Mack <span dir="ltr"><<a href="mailto:daniel@caiaq.de">daniel@caiaq.de</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Wed, Aug 11, 2010 at 11:26:20PM +0200, Marek Vasut wrote:<br>
> Dne St 11. srpna 2010 16:33:45 Daniel Mack napsal(a):<br>
> > Hi Yuri,<br>
> ><br>
> > thanks for the patch.<br>
> ><br>
> > On Wed, Aug 11, 2010 at 04:54:13PM +0400, Yuri Ludkevich wrote:<br>
> > > Ads properly initialization to GPIO4 ( alt. fn. #1, nCS3; because GPIO4<br>
> > > and GPIO4_2 cannot be<br>
> > > configured as GPIO simultaneously ) so GPIO4_2 which used as irq line<br>
> > > from UCB1400 may be<br>
> > > detected while irq autoprobing routine.<br>
> ><br>
> > This looks fine to me, but Marek wanted to rework the board support in<br>
> > order to unify the GPIO configs for better readability. Marek, is there<br>
> > any tree which contains your changes already?<br>
> ><br>
> I hope there will be tomorrow ...<br>
<br>
</div>Yuri, could you check out Marek's tree from<br>
<br>
git://<a href="http://git.kernel.org/pub/scm/linux/kernel/git/marex/pxa-linux-2.6.git" target="_blank">git.kernel.org/pub/scm/linux/kernel/git/marex/pxa-linux-2.6.git</a> work<br>
<br>
(not that "work" ist the branch you'll need to work on).<br>
<br>
You'll see that colibri-pxa320.c looks a lot different now, so your<br>
patch should be a one-liner now.<br>
<br>
Also, more testing of this code is certainly appreciated :)<br>
<font color="#888888"><br></font></blockquote><div><br><br>I have looked at code and I have couple of questions about colibri-pxa320.c and colibri-evalboard.c:<br>Why colibri_pxa320_evalboard_pin_config[] placed in colibri-pxa320.c, not in evalboard?<br>
Why there is no defconfig for colibri pxa320?<br><br>BTW: we have our own board which very similar to colibri evalboard - same RTC, UCB1400 as sound and touch controller. But we have USB hub onboard, do not use FFUART and use 800x600 screen - so we make our own file with board init stuff. May be colibri_pxa320_evalboard_pin_config[] and pxafb_mode_info/pxa_fb_mach info structures also can be moved to evalboard file?<br>
</div></div><br>