<html><body bgcolor="#FFFFFF"><div><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">On 28 Jul 2010, at 07:48, Maurus Cuelenaere <<a href="mailto:mcuelenaere@gmail.com">mcuelenaere@gmail.com</a>> wrote:</span><br></div><blockquote type="cite"><div><blockquote type="cite"><font class="Apple-style-span" color="#000000"><br></font></blockquote><blockquote type="cite"><span>+<span class="Apple-tab-span" style="white-space:pre"> </span>struct sdhci_s3c *sc = sdhci_priv(host);</span><br></blockquote><blockquote type="cite"><span>+</span><br></blockquote><blockquote type="cite"><span>+<span class="Apple-tab-span" style="white-space:pre"> </span>if (sc->vmmc) {</span><br></blockquote><blockquote type="cite"><span>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>int ret = regulator_disable(sc->vmmc);</span><br></blockquote><blockquote type="cite"><span>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>if (ret)</span><br></blockquote><blockquote type="cite"><span>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>return ret;</span><br></blockquote><blockquote type="cite"><span>+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>mdelay(2);</span><br></blockquote><span></span><br><span>Shouldn't these delays be handled in the regulator framework itself?</span><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#0023A3"><br></font></font></div></blockquote><br><div>A 2ms delay on power down seems suspicious for a regulator. I'm not sure why this is required but if it is I suspect it's due to a large cap on the regulator output and light load rather than something that's always true for whatever regulator is providing the supply.</div></body></html>