Hi Linus,<br><br><div class="gmail_quote">2010/4/1 Linus Walleij <span dir="ltr"><<a href="mailto:linus.ml.walleij@gmail.com">linus.ml.walleij@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
2010/3/31 Lemetayer Jean Marie <<a href="mailto:jeanmarie.lemetayer@altran.com">jeanmarie.lemetayer@altran.com</a>>:<br>
<div class="im"><br>
> +#ifdef CONFIG_VENDOR_TOOL_COMPATIBILITY<br>
> +static struct nand_ecclayout nomadik_ecc_layout = {<br>
> + .eccbytes = 3 * 4,<br>
> + .eccpos = {<br>
> + 0x28, 0x29, 0x2A,<br>
> + 0x2B, 0x2C, 0x2D,<br>
> + 0x2E, 0x2F, 0x30,<br>
> + 0x31, 0x32, 0x33},<br>
> + .oobfree = {{0x02, 0x26}, {0x34, 0x0C} },<br>
> +};<br>
> +#else<br>
> static struct nand_ecclayout nomadik_ecc_layout = {<br>
> .eccbytes = 3 * 4,<br>
> .eccpos = { /* each subpage has 16 bytes: pos 2,3,4 hosts ECC */<br>
> @@ -54,6 +65,7 @@ static struct nand_ecclayout nomadik_ecc_layout = {<br>
> /* let's keep bytes 5,6,7 for us, just in case we change ECC algo */<br>
> .oobfree = { {0x08, 0x08}, {0x18, 0x08}, {0x28, 0x08}, {0x38, 0x08}<br>
> },<br>
> };<br>
> +#endif<br>
<br>
</div>Acked-by: Linus Walleij <<a href="mailto:linus.walleij@stericsson.com">linus.walleij@stericsson.com</a>><br>
<br>
I don't think any of this layout belongs in the driver itself frankly speaking,<br>
I am facing the need to use this in U300 and we use yet *another*<br>
ECC layout with the FSMC, so we have to add yet another #ifdef.<br>
However I can fix that up with a patch on top of this one after it's<br>
queued.<br>
<br>
Yours,<br>
Linus Walleij<br></blockquote><div><br>What king of modification would you do ?<br>Do you think it shall be queued before your submission ?<br><br>Regards,<br>JM<br></div></div>