<br><br><div class="gmail_quote">2009/11/30 Sascha Hauer <span dir="ltr"><<a href="mailto:s.hauer@pengutronix.de">s.hauer@pengutronix.de</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On Mon, Nov 30, 2009 at 02:09:16PM +0100, javier Martin wrote:<br>
> From fa87b65915e78ad29a8e4f3f22b26ed0fa6dc7f5 Mon Sep 17 00:00:00 2001<br>
><br>
> > From: Sascha Hauer <<a href="mailto:s.hauer@pengutronix.de">s.hauer@pengutronix.de</a>><br>
> > Date: Mon, 30 Nov 2009 13:31:29 +0100<br>
> > Subject: [PATCH] i.MX27 audmux: Fix register offsets<br>
> ><br>
> > The PPCR registers start at 0x10, not 0xc. Fix this.<br>
> ><br>
> > Signed-off-by: Sascha Hauer <<a href="mailto:s.hauer@pengutronix.de">s.hauer@pengutronix.de</a>><br>
> > ---<br>
> > arch/arm/plat-mxc/include/mach/audmux.h | 6 +++---<br>
> > 1 files changed, 3 insertions(+), 3 deletions(-)<br>
> ><br>
> > diff --git a/arch/arm/plat-mxc/include/mach/audmux.h<br>
> > b/arch/arm/plat-mxc/include/mach/audmux.h<br>
> > index 5cd6466..dcc12d4 100644<br>
> > --- a/arch/arm/plat-mxc/include/mach/audmux.h<br>
> > +++ b/arch/arm/plat-mxc/include/mach/audmux.h<br>
> > @@ -4,9 +4,9 @@<br>
> > #define MX27_AUDMUX_HPCR1_SSI0 0<br>
> > #define MX27_AUDMUX_HPCR2_SSI1 1<br>
> > #define MX27_AUDMUX_HPCR3_SSI_PINS_4 2<br>
> > -#define MX27_AUDMUX_PPCR1_SSI_PINS_1 3<br>
> > -#define MX27_AUDMUX_PPCR2_SSI_PINS_2 4<br>
> > -#define MX27_AUDMUX_PPCR3_SSI_PINS_3 5<br>
> > +#define MX27_AUDMUX_PPCR1_SSI_PINS_1 4<br>
> > +#define MX27_AUDMUX_PPCR2_SSI_PINS_2 5<br>
> > +#define MX27_AUDMUX_PPCR3_SSI_PINS_3 6<br>
> ><br>
><br>
> Be careful,<br>
> I think this patch breaks some of the boards currently using<br>
> MXC_AUDMUX_V1_PCR_RXDSEL(x) and similar macros defined in mach/audmux.h (for<br>
> example pcm038).<br>
> For those macros the old AUDMUX register indexes are fine.<br>
><br>
> I suggest fixing this inside audmux_v1.c instead of modifying mach/audmux.h.<br>
<br>
</div></div>Ok. The AUDMUX V1 is used on i.MX21 and i.MX27 and both have this hole<br>
in the register space, so fixing it in the driver should be safe.<br>
<br>
How about this one then?<br>
<br>
Sascha<br>
<br>
<br>