yeah,i agree<br><div><br><br></div><div></div><br><pre>在2009-11-06&nbsp;11:18:45，"Harald&nbsp;Welte"&nbsp;&lt;laforge@gnumonks.org&gt;&nbsp;写道：
&gt;Hi&nbsp;Marek,
&gt;
&gt;On&nbsp;Tue,&nbsp;Oct&nbsp;13,&nbsp;2009&nbsp;at&nbsp;10:11:07AM&nbsp;+0200,&nbsp;Marek&nbsp;Szyprowski&nbsp;wrote:
&gt;
&gt;&gt;&nbsp;S5PC110&nbsp;and&nbsp;S5PC100&nbsp;register&nbsp;maps&nbsp;differs&nbsp;in&nbsp;many&nbsp;places,&nbsp;rename&nbsp;all
&gt;&gt;&nbsp;defined&nbsp;registers&nbsp;to&nbsp;be&nbsp;S5PC100&nbsp;specific.&nbsp;System&nbsp;map&nbsp;has&nbsp;been&nbsp;also&nbsp;updated
&gt;&gt;&nbsp;to&nbsp;cover&nbsp;more&nbsp;integrated&nbsp;peripherals.
&gt;
&gt;The&nbsp;general&nbsp;idea&nbsp;of&nbsp;this&nbsp;patch&nbsp;is&nbsp;fine.&nbsp;&nbsp;However,&nbsp;I&nbsp;have&nbsp;some&nbsp;questions:
&gt;
&gt;&gt;&nbsp;&nbsp;/*&nbsp;System&nbsp;*/
&gt;&gt;&nbsp;-#define&nbsp;S5PC100_PA_SYS                (0xE0100000)
&gt;&gt;&nbsp;-#define&nbsp;S5PC100_PA_CLK                (S5PC100_PA_SYS&nbsp;+&nbsp;0x0)
&gt;&gt;&nbsp;-#define&nbsp;S5PC100_PA_PWR                (S5PC100_PA_SYS&nbsp;+&nbsp;0x8000)
&gt;&gt;&nbsp;+#define&nbsp;S5PC100_PA_CLK                (0xE0100000)
&gt;&gt;&nbsp;+#define&nbsp;S5PC100_PA_CLK_OTHER        (0xE0200000)
&gt;&gt;&nbsp;+#define&nbsp;S5PC100_PA_PWR                (0xE0108000)
&gt;
&gt;this&nbsp;is&nbsp;more&nbsp;like&nbsp;a&nbsp;rename.&nbsp;&nbsp;Why&nbsp;was&nbsp;this&nbsp;done?&nbsp;&nbsp;It&nbsp;would&nbsp;be&nbsp;good&nbsp;to&nbsp;explain&nbsp;in
&gt;the&nbsp;commitlog
&gt;
&gt;&gt;&nbsp;+/*&nbsp;GPIO&nbsp;*/
&gt;&gt;&nbsp;+#define&nbsp;S5PC100_PA_GPIO                (0xE0300000)
&gt;&gt;&nbsp;+#define&nbsp;S5PC1XX_PA_GPIO                S5PC100_PA_GPIO
&gt;&gt;&nbsp;+#define&nbsp;S5PC1XX_VA_GPIO                S3C_ADDR(0x00500000)
&gt;
&gt;If&nbsp;the&nbsp;address&nbsp;is&nbsp;different&nbsp;for&nbsp;c100&nbsp;and&nbsp;c110:&nbsp;why&nbsp;do&nbsp;we&nbsp;need&nbsp;a&nbsp;S5CP1XX_*
&gt;definition?&nbsp;&nbsp;In&nbsp;my&nbsp;personal&nbsp;opinion,&nbsp;all&nbsp;those&nbsp;compile-time&nbsp;defines&nbsp;are&nbsp;a
&gt;kludge&nbsp;and&nbsp;we&nbsp;should&nbsp;not&nbsp;introduce&nbsp;more&nbsp;of&nbsp;them.&nbsp;&nbsp;They&nbsp;will&nbsp;bite&nbsp;us&nbsp;in&nbsp;the&nbsp;back
&gt;if&nbsp;we&nbsp;ever&nbsp;in&nbsp;the&nbsp;future&nbsp;want&nbsp;to&nbsp;build&nbsp;a&nbsp;kernel&nbsp;that&nbsp;can&nbsp;boot&nbsp;on&nbsp;both&nbsp;c100&nbsp;and
&gt;c110.
&gt;
&gt;&gt;&nbsp;&nbsp;/*&nbsp;ETC&nbsp;*/
&gt;&gt;&nbsp;&nbsp;#define&nbsp;S5PC100_PA_SDRAM        (0x20000000)
&gt;&gt;&nbsp;+#define&nbsp;S5PC1XX_PA_SDRAM        S5PC100_PA_SDRAM
&gt;
&gt;Again&nbsp;here.&nbsp;We&nbsp;already&nbsp;have&nbsp;the&nbsp;c100&nbsp;specific&nbsp;define.&nbsp;&nbsp;Why&nbsp;add&nbsp;a&nbsp;new&nbsp;c1xx&nbsp;define?
&gt;
&gt;&gt;&nbsp;&nbsp;        /*&nbsp;Maintainer:&nbsp;Byungho&nbsp;Min&nbsp;&lt;bhmin@samsung.com&gt;&nbsp;*/
&gt;&gt;&nbsp;-        .phys_io        =&nbsp;S5PC1XX_PA_UART&nbsp;&amp;&nbsp;0xfff00000,
&gt;&gt;&nbsp;+        .phys_io        =&nbsp;S5PC100_PA_UART&nbsp;&amp;&nbsp;0xfff00000,
&gt;
&gt;this&nbsp;is&nbsp;the&nbsp;change&nbsp;I&nbsp;like.
&gt;
&gt;&gt;&nbsp;&nbsp;        .io_pg_offst        =&nbsp;(((u32)S5PC1XX_VA_UART)&nbsp;&gt;&gt;&nbsp;18)&nbsp;&amp;&nbsp;0xfffc,
&gt;&gt;&nbsp;-        .boot_params        =&nbsp;S5PC100_PA_SDRAM&nbsp;+&nbsp;0x100,
&gt;&gt;&nbsp;+        .boot_params        =&nbsp;S5PC1XX_PA_SDRAM&nbsp;+&nbsp;0x100,
&gt;
&gt;This&nbsp;is&nbsp;the&nbsp;wrong&nbsp;kind&nbsp;of&nbsp;change,&nbsp;from&nbsp;my&nbsp;point&nbsp;of&nbsp;view.&nbsp;&nbsp;We&nbsp;don't&nbsp;know&nbsp;yet
&gt;if&nbsp;all&nbsp;future&nbsp;s5pc1xx&nbsp;products&nbsp;will&nbsp;also&nbsp;have&nbsp;the&nbsp;same&nbsp;address,&nbsp;do&nbsp;we?
&gt;
&gt;--&nbsp;
&gt;-&nbsp;Harald&nbsp;Welte&nbsp;&lt;laforge@gnumonks.org&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;http://laforge.gnumonks.org/
&gt;============================================================================
&gt;"Privacy&nbsp;in&nbsp;residential&nbsp;applications&nbsp;is&nbsp;a&nbsp;desirable&nbsp;marketing&nbsp;option."
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;(ETSI&nbsp;EN&nbsp;300&nbsp;175-7&nbsp;Ch.&nbsp;A6)
&gt;
&gt;_______________________________________________
&gt;linux-arm-kernel&nbsp;mailing&nbsp;list
&gt;linux-arm-kernel@lists.infradead.org
&gt;http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
</pre><br><br><span title="neteasefooter"/><hr/>
<a href="http://allyes.nie.163.com/main/adfclick?db=afanie&bid=1254,611,23&cid=145,4,1&sid=1351&show=ignore&url=http://tx2.163.com/fab.html">09年新晋3D主流网游《天下贰》，网易六年亿资打造</a>
</span>