[PATCH v3 6/7] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node

[Laurent Pinchart]

Hi Frank,

On Tue, Aug 11, 2026 at 11:51:00AM -0500, Frank Li wrote:
> On Mon, Aug 10, 2026 at 10:08:00PM +0300, Laurent Pinchart wrote:
> > On Mon, Aug 10, 2026 at 01:55:41PM -0500, Frank Li wrote:
> > > On Mon, Aug 10, 2026 at 09:06:03PM +0300, Laurent Pinchart wrote:
> > > > The clock-frequency for camera sensors has been deprecated in favour of
> > > > the assigned-clocks and assigned-clock-rates properties. Replace it in
> > > > the device tree.
> > >
> > > Remove "clock-frequency" may break back compatiblity.
> > >
> > > A similar case
> > > https://lore.kernel.org/imx/20d37ab7-308e-4f07-96dc-7ae011af76d0@kernel.org/
> > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/
> > >
> > > Need provide judgement in commit message about impact of break ABI.
> >
> > What ABI breakage ? The latest kernel supports the updated bindings
> > (merged in commit aa1826696a55 ("dt-bindings: media: Deprecate
> > clock-frequency property for camera sensors") in v6.18).
> 
> Dts now not only use by kenrel. such as uboot may use the same dts file.
> 
> uboot may still use "clock-frequency". but uboot unlikely use camera. for
> this case, just need mention at commit message
> 
> "lock-frequency property for camera sensor have deprecated since
>  ("dt-bindings: media: Deprecate  clock-frequency property for camera
>  sensors") in v6.18, no known other user like (uboot) use it. So drop
> it safely"

How about the following ?

----
The clock-frequency for camera sensors has been deprecated in favour of
the assigned-clocks and assigned-clock-rates properties since commit
aa1826696a55 ("dt-bindings: media: Deprecate clock-frequency property
for camera sensors") in v6.18. The Linux kernel ov5645 driver has been
handling the deprecated property as optional since the same kernel
version.

Replace the property in the device tree. There are no known users of the
property outside of the Linux kernel. In particular, U-Boot doesn't
operate the camera. Switching to the new bindings will therefore not
introduce any breakage.
----

If that's fine with you, can you please update the commit message when
taking the patch ?

> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > > ---
> > > > Changes since v1:
> > > >
> > > > - Drop added blank line
> > > > ---
> > > >  arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi | 4 +++-
> > > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > > > index ca4cb986efbc..0cc05d084f9b 100644
> > > > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > > > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi
> > > > @@ -233,7 +233,9 @@ camera at 3c {
> > > >  		pinctrl-0 = <&pinctrl_ov5645>;
> > > >  		reg = <0x3c>;
> > > >  		clocks = <&clks IMX6QDL_CLK_CKO2>;
> > > > -		clock-frequency = <24000000>;
> > > > +		assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> > > > +		assigned-clock-rates = <24000000>;
> > > > +
> > > >  		vdddo-supply = <&reg_1p8v>;
> > > >  		vdda-supply = <&reg_2p8v>;
> > > >  		vddd-supply = <&reg_1p5v>;

-- 
Regards,

Laurent Pinchart