[PATCH 0/7] arm64: hibernate: dust off the suspend/cleanup rework
Bradley Morgan
brads at mainlining.org
Thu Sep 3 04:26:11 PDT 2026
On 3 September 2026 11:53:59 BST, Will Deacon <will at kernel.org> wrote:
>On Wed, Sep 02, 2026 at 03:03:07PM +0100, Mark Rutland wrote:
>> On Wed, Sep 02, 2026 at 02:51:22PM +0100, Bradley Morgan wrote:
>> > On 2 September 2026 14:50:22 BST, Mark Rutland <mark.rutland at arm.com>
>> > wrote:
>> > >On Tue, Aug 25, 2026 at 08:58:32PM +0000, Bradley Morgan wrote:
>> > >> This comes out of the hibernate resume discussion where Will asked
>if
>> > >> the restored kernel's hyp vectors are reinstalled before we come
>back
>> > >> from swsusp_arch_suspend() and free the reserved pages. Rather than
>> > >> answer with a one off fix, this series reworks resume to look like
>a
>> > >> resume from idle, which makes the answer fall out on its own.
>> > >>
>> > >> The series leans on Mark Rutland's old work for inspiration, he had
>the
>> > >> same end goal in a branch from back then:
>> > >>
>> > >>
>> >
>>https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/suspend/cleanup
>> > >
>> > >Most of the series seems to be a rebased of those patches, just with
>> > >paraphrased commit messages and my S-o-B lines dropped. As commented
>on
>> > >patch 4, I do not think that is appropriate.
>> >
>> > Same question as patch 2
>> >
>> > If you want your S-O-B added, ok fine, but yeah.
>>
>> As on patch 2, please read the documentation before continuing futher.
>>
>> > Do you think this series itself is good?
>>
>> No. At present I think it's in a worse state than it was in my branch,
>> because portions have changed, with no rationale and no clear benefit.
>>
>> Hence my ask to Catalin and Will to NOT pick this up for now.
>
>I wasn't going to pick them up with the incorrect authorship, but it's
>worth noting that Bradley's patch _does_ fix one of the hibernation
>problems and has been tested by Vladimir:
>
>https://lore.kernel.org/all/20260809213615.11646-1-include@grrlz.net/
>
>I would prefer to take your complete set of patches, but if you don't
>want that then should I just take the above for now? Prior to this
>series, there has been no activity for nearly two years on your branch,
>so I'd prefer to get _something_ in, even if it only fixes some of the
>problems.
>
So your taking the bugfix? I'll do V2 later, you'd need to review my sleep
patch tho.
>Will
--- Thanks!
https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@grrlz.net/
More information about the linux-arm-kernel
mailing list