[PATCH v8 1/6] dt-bindings: rtc: Add pinctrl for S35390A

[Krzysztof Kozlowski]

On Tue, Sep 01, 2026 at 01:28:36PM +0000, Markus Probst wrote:
> On Tue, 2026-09-01 at 12:05 +0200, Krzysztof Kozlowski wrote:
> > > +patternProperties:
> > > +  "^pins":
> > > +    type: object
> > > +    additionalProperties: false
> > > +
> > > +    patternProperties:
> > > +      "-pins$":
> > > +        type: object
> > > +        additionalProperties: false
> > > +
> > > +        allOf:
> > > +          - $ref: /schemas/pinctrl/pinmux-node.yaml#
> > > +
> > > +        properties:
> > > +          pins:
> > > +            minItems: 1
> > > +            items:
> > > +              enum:
> > > +                - int1
> > > +                - int2
> > > +
> > > +          function:
> > > +            description: |
> > > +              Pin function:
> > > +              - ignore:  Preserve the previous state.
> > > +              - disable: Disable pin output.
> > > +              - wakeup:  Output wakes up the system.
> > > +              - clock:   Output clock pulse.
> > > +              - pmin1:   Minute periodical output with 50% duty.
> > > +              - pmin2:   Minute periodical output L for 7.81 ms.
> > > +                         Can only be used with pin int1.
> > > +            enum:
> > > +              - ignore
> > > +              - disable
> > > +              - wakeup
> > > +              - clock
> > > +              - pmin1
> > > +              - pmin2
> > > +
> > > +        required:
> > > +          - pins
> > > +          - function
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +
> > > +unevaluatedProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    i2c {
> > > +        #address-cells = <1>;
> > > +        #size-cells = <0>;
> > > +
> > > +        rtc at 30 {
> > > +            compatible = "sii,s35390a";
> > > +            reg = <0x30>;
> > > +            pinctrl-0 = <&rtc_pins_default>;
> > > +            pinctrl-names = "default";
> > > +
> > > +            wakeup-parent = <&int>;
> > 
> > I don't understand this need. Device does not generate interrupts - no
> > interrupts property - thus how can it wakeup?
> It is just an example.

But examplep should be complete and represent some real thing, not just
stiched random properties.

> 
> > 
> > As explained in commit msg, the signal at int1 goes to the SoC, right?
> I assume.
> 
> > So where does it go? To which pin of which device? &int?
> For my Synology DS923+ NAS, I do not have schematics. I only know for
> sure from source code that INT1 is used for wakeup and I can confirm
> that this does indeed wake the device up. 
> 
> > 
> > Can you show complete upstream DTS using this?
> There is arch/arm/boot/dts/ti/omap/am3517-som.dtsi, which has the pin
> output of INT1 routed to a gpio pin. INT2 isn't connected at all.
> According to the public schematic [1], this looks accurate.

And INT1 is part of the interrupts.

What I do not get, how this can wakeup anything without generating
an interrupt?

Best regards,
Krzysztof