[PATCH v3 3/9] firmware: arm_scmi: Convert OF-only paths to generic fwnode in SCMI core

[Sudeep Holla]

On Wed, Sep 02, 2026 at 04:29:11PM -0700, Jonathan Cameron wrote:
> On Wed, 2 Sep 2026 14:39:31 +0100
> Sudeep Holla <sudeep.holla at kernel.org> wrote:
> 
> > On Mon, Aug 24, 2026 at 10:39:29AM -0700, Jonathan Cameron wrote:

[...]

> > > 
> > > There are no early exits yet and I can't see any added later in the series.
> > > So the scoped bit is irrelevant.  I don't mind the change on basis of
> > > hardening or similar but it needs a comment in the patch description to 
> > > justify that.
> > >   
> > 
> > This is mainly to release the reference taken in
> > fwnode_get_next_available_child_node(). It is taken explicitly via
> > fwnode_handle_get() before scmi_create_protocol_devices() as discussed
> > below.
> 
> When the loop continues to normal termination the puts are all there
> anyway as part of the iterators.  The _scoped case just deals with
> early exits via break or return.

You're right. For some reason I conflated the iterator-owned reference 
won't be released and _scoped version is needed. This loop has no early
exit, so I will use the non-scoped iterator here. Thanks again.

-- 
Regards,
Sudeep