[PATCH v2 0/5] Add CIX Sky1 USB3/USBSSP support
Hongliang Yang
hongliang.yang at cixtech.com
Tue Sep 1 20:21:29 PDT 2026
Add USB3 PHY binding and driver, Cadence USBSSP glue binding and
driver, and USB4/USB5 device tree nodes for the CIX Sky1 SoC.
This series adds support for the USB4 and USB5 controllers (based on
Cadence USBSSP DRD) found on the CIX Sky1 SoC, along with their
associated multi-port USB3 PHY.
Changes in v2:
- Split the dt-bindings patch into separate PHY and USBSSP binding
patches with proper subsystem subject prefixes.
- Follow the DTS coding style in the bindings and DTS (property
ordering, no redundant unit-address suffixes in examples); examples
pass dt-check-style in strict mode.
- Drop the redundant "_clk" suffix and "reset"/"usb" prefixes from
clock-names and reset-names ("apb_clk" -> "apb", "ref_clk" ->
"ref", "reset"/"preset" -> "core"/"apb", "usb_preset"/"usb_reset"
-> "apb"/"core", "sof_clk"/"usb_aclk"/"lpm_clk"/"usb_pclk" ->
"sof"/"axi"/"lpm"/"apb").
- Rename reg-names "axi_property"/"controller_status" to
"axi"/"controller".
- Rename the Cadence core child nodes from usb-controller@ to the
conventional usb@ node name.
- Drop the cix,axi-bmax-value, sof_clk_freq and lpm_clk_freq
properties. These are fixed per SoC and are now hardcoded in the
glue driver.
- Rename cix,usb_syscon -> cix,usb-syscon to follow devicetree
property naming conventions.
- Use additionalProperties: false instead of
unevaluatedProperties: false in the PHY binding (no other schema
is referenced).
- Fix unit addresses in the binding example and DTS nodes to match
the first reg address (usb at 91c0314, usb at 91c0324).
- Enable the usb4/usb5 wrapper nodes, usb3_phy4 PHY and its ports in
the Orion O6 board file so the controllers can probe.
- Add reg properties to the usb-port at 0/usb-port at 1 child nodes.
- Fix the reg-names order of the cdns,usb3 child nodes to
"otg", "xhci", "dev" as required by the binding schema.
- Use devm_reset_control_get_exclusive() instead of the deprecated
devm_reset_control_get() in the USB3 PHY and glue drivers.
- Propagate error codes from the PHY driver probe paths instead of
returning 0 unconditionally.
- Use device_for_each_child_node_scoped() to drop the manual
of_node_put() and fix the double-put/uninitialized access on the
probe error path.
- Remove the phy_create_lookup() entries which leaked on unbind and
were unused (consumers reference the PHY via the DT "phys"
phandle).
- Assert (not deassert) the hardware resets on the sky1_u3phy_init()
error path.
- Add MODULE_DEVICE_TABLE(of, ...) for automatic module loading.
Hongliang Yang (5):
dt-bindings: phy: Add CIX Sky1 USB3 PHY
dt-bindings: usb: Add CIX Sky1 USBSSP controller
phy: cix: Add CIX Sky1 USB3 PHY driver
usb: cdns3: Add CIX Sky1 glue driver
arm64: dts: cix: Add USB4/USB5 nodes for Sky1
.../bindings/phy/cix,sky1-usb3-phy.yaml | 107 +++
.../bindings/usb/cix,sky1-usbssp.yaml | 137 ++++
MAINTAINERS | 3 +
arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 50 ++
arch/arm64/boot/dts/cix/sky1.dtsi | 125 ++++
drivers/phy/Kconfig | 1 +
drivers/phy/Makefile | 1 +
drivers/phy/cix/Kconfig | 20 +
drivers/phy/cix/Makefile | 6 +
drivers/phy/cix/phy-cix-usb3.c | 407 +++++++++++
drivers/phy/cix/phy-cix-usbdp.h | 310 ++++++++
drivers/usb/cdns3/Kconfig | 13 +
drivers/usb/cdns3/Makefile | 1 +
drivers/usb/cdns3/cdnsp-sky1.c | 673 ++++++++++++++++++
drivers/usb/cdns3/cdnsp-sky1.h | 127 ++++
15 files changed, 1981 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/cix,sky1-usb3-phy.yaml
create mode 100644 Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml
create mode 100644 drivers/phy/cix/Kconfig
create mode 100644 drivers/phy/cix/Makefile
create mode 100644 drivers/phy/cix/phy-cix-usb3.c
create mode 100644 drivers/phy/cix/phy-cix-usbdp.h
create mode 100644 drivers/usb/cdns3/cdnsp-sky1.c
create mode 100644 drivers/usb/cdns3/cdnsp-sky1.h
--
2.54.0
More information about the linux-arm-kernel
mailing list