[PATCH] clk: meson: Fix PLL enable timing
Jerome Brunet
jbrunet at baylibre.com
Fri Oct 30 02:04:05 PDT 2026
> The hardware requires a 50us delay after setting the PLL enable
> bit to meet its timing requirements.
>
> Without this delay, GP0 and HIFI PLLs on Amlogic T7, SM1 and C3
> may fail to lock under stress testing.
>
> For example, enabling the GP0 PLL at 1512MHz may lose lock and
> result in an output I/O error:
>
> echo 1512000000 > /sys/kernel/debug/clk/gp0_pll/clk_rate
> echo 1 > /sys/kernel/debug/clk/gp0_pll/clk_prepare_enable
> sh: write error: I/O error
This is something for the cover letter or bellow the --- for a single change series.
>
> Add the required 50us delay after enabling the PLL.
>
> Testing on GXL shows that the PLL works correctly without the
> additional delay and continues to lock successfully after the
> 50us delay is added.
>
> On A1, remove the redundant 10us delay before enabling the
> self-adaption current module, as the new PLL enable delay already
> covers this timing requirement.
>
> Tested on: T7, C3, S4, AXG, GXL, SM1 and A1.
>
> Fixes: e40c7e3cda07 ("clk: meson: clk-pll: add enable bit")
This is the commit which introduced the enable bit and it is not really
what you are fixing here
A more likely candidate is b6ec400aa153 which introduced the delay
sequence you are modifying here.
I've got this other patch addressing PLL delays in my queue:
https://lore.kernel.org/all/20251031-optimize_pll_driver-v3-2-92f3b2f36a83@amlogic.com/
Which one is it ? both ?
Please consolidate and resubmit.
--
Jerome
More information about the linux-arm-kernel
mailing list