[PATCH net-next v4 2/2] net: stmmac: Stop Tx queue when (en|dis)abling XSK pools

Paolo Abeni pabeni at redhat.com
Thu Oct 29 03:14:01 PDT 2026


On 10/26/26 08:24, netdev-bot+sashiko at kernel.org wrote:
> - [High] stmmac_xdp_enable_pool() (stmmac_xdp.c:59) and
>    stmmac_xdp_disable_pool() (stmmac_xdp.c:102) now call…
> - [Medium] The patch only works if __QUEUE_STATE_DRV_XOFF stays set from
>    stmmac_xdp_stop_tx_queue() until the ring is rebuilt.
> - [Medium] In stmmac_xdp_xmit_xdpf(), first_entry and entry are read from
>    tx_q->cur_tx when the locals are declared (stmmac_main.c:5263-5264).
I understand that the comments raised on patch 1/2 are sort of pre-existing,
as the reported races can be reached by __stmmac_release(), but the above
ones look legit and unaddressed/unanswered.

You can target `net` with the next revision, and please reply also to
already discussed comments, even with just a pointer to the previous
discussion.

/P




More information about the linux-arm-kernel mailing list