[PATCH v3 2/4] dt-bindings: serial: snps-dw-apb-uart: add Allwinner H616
Krzysztof Kozlowski
krzk at kernel.org
Tue Oct 27 03:04:54 PDT 2026
On 27/10/2026 11:02, Chen-Yu Tsai wrote:
>>>>> + - if:
>>>>> + properties:
>>>>> + compatible:
>>>>> + contains:
>>>>> + const: allwinner,sun50i-h616-uart
>>>>> + then:
>>>>> + properties:
>>>>> + fifo-size:
>>>>> + const: 256
>>>>> + required:
>>>>> + - fifo-size
>>>>
>>>> Why do you require fifo-size if is const? It is implied by the
>>>> compatible.
>>>
>>> H616 has a fixed depth, but other sunxi integrations have different
>>> depths between UART instances. For example, D1 has 64-byte FIFOs on
>>> UART0 and 256-byte FIFOs on UART1–5.
>>>
>>> Should I keep this explicit for consistency for all sunxi uarts?
>>
>> I am confused, there are no other instances here.
>
> I think the point is that it is going to be needed in the future when
> we add the compatibles for the SoCs that do have UARTs with different
> FIFO sizes.
Then we add it. We don't create code which is not used.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list