[PATCH 2/4] irqchip/alpine-msi: Drop redundant asm/msi.h include

Radu Rendec radu at rendec.net
Sat Oct 24 11:20:28 PDT 2026


On Wed, 2026-09-23 at 08:37 +0000, Eliav Farber wrote:
> The driver already includes <linux/msi.h>, which itself pulls in
> <asm/msi.h>, so the explicit arch include is redundant. Remove it;
> checkpatch also flags the direct use of the asm header in favour of
> the linux one. No functional change.
> 
> Signed-off-by: Eliav Farber <farbere at amazon.com>
> ---
>  drivers/irqchip/irq-alpine-msi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c
> index 0d97abb85e16..20f1f7f7612b 100644
> --- a/drivers/irqchip/irq-alpine-msi.c
> +++ b/drivers/irqchip/irq-alpine-msi.c
> @@ -21,7 +21,6 @@
>  #include <linux/slab.h>
>  
>  #include <asm/irq.h>
> -#include <asm/msi.h>
>  
>  /* MSIX message address format: local GIC target */
>  #define ALPINE_MSIX_SPI_TARGET_CLUSTER0		BIT(16)

Reviewed-by: Radu Rendec <radu at rendec.net>



More information about the linux-arm-kernel mailing list