[PATCH v11 06/11] iommu/arm-smmu-v3: Add ARM_SMMU_OPT_KDUMP_ADOPT for kdump kernel

Nicolin Chen nicolinc at nvidia.com
Thu Oct 22 08:16:31 PDT 2026


On Thu, Oct 22, 2026 at 09:41:18AM +0100, John Garry wrote:
> BTW, on another point, nobody checks the specific error code returned value
> from arm_smmu_kdump_adopt_strtab(), so you can consider making it return a
> bool.

No.

Following Documentation/process/coding-style.rst,

16) Function return values and names

	If the name of a function is an action or an imperative command,
	the function should return an error-code integer.  If the name
	is a predicate, the function should return a "succeeded" boolean.

Thanks
Nicolin



More information about the linux-arm-kernel mailing list