[PATCH v10 03/10] clk: nuvoton: ma35d1: Retrieve HXT/LXT from DT when possible
Miquel Raynal
miquel.raynal at bootlin.com
Mon Oct 19 01:13:08 PDT 2026
>> + /*
>> + * Old DTs do not describe the low-speed crystal. They may also expect
>> + * an HXT output from this driver. In practice, nobody should use these
>> + * clocks directly, but they must be kept for backward compatility
>> + * purposes.
>> + */
>> + if (num_clks == 1) {
>> + hws[HXT] = ma35d1_clk_fixed("hxt", 24000000);
>> + hws[LXT] = ma35d1_clk_fixed("lxt", 32768);
>> + }
>
> The above is fine but the problem is those IDs still exist and something like
> <&clk HXT> is still valid in DT but now does not provide a clock
> anymore.
Yeah, it's hard to prevent, but people would immediately face errors
when developing anyway.
> This is why I asked if you about removing the ID. At the very least a comment is
> needed next to the IDs saying those are obsolete and should not be used.
Ok, 'next to the IDs' may be relevant indeed, I'll add that.
Thanks,
Miquèl
More information about the linux-arm-kernel
mailing list