[PATCH v2 04/24] dt-bindings: clock: Add ZTE ZX279128S CRM clock bindings

[Krzysztof Kozlowski]

On Wed, Oct 14, 2026 at 08:20:44AM +0100, Navid Ghahremani wrote:
> Add Device Tree binding schemas for the ZTE ZX279128S clock controllers:
> topcrm, lspcrpm, and crm2. Define fixed clock lists and simple-mfd
> for child nodes inside topcrm.
> 
> Signed-off-by: Navid Ghahremani <ghahramani.navid at gmail.com>
> ---
>  .../bindings/clock/zte,zx279128s-crm2.yaml    |  48 +++++++++
>  .../bindings/clock/zte,zx279128s-lspcrpm.yaml | 101 ++++++++++++++++++
>  .../bindings/clock/zte,zx279128s-topcrm.yaml  |  86 +++++++++++++++
>  include/dt-bindings/clock/zte,zx279128s-crm.h |  51 +++++++++
>  4 files changed, 286 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/zte,zx279128s-crm2.yaml
>  create mode 100644 Documentation/devicetree/bindings/clock/zte,zx279128s-lspcrpm.yaml
>  create mode 100644 Documentation/devicetree/bindings/clock/zte,zx279128s-topcrm.yaml
>  create mode 100644 include/dt-bindings/clock/zte,zx279128s-crm.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/zte,zx279128s-crm2.yaml b/Documentation/devicetree/bindings/clock/zte,zx279128s-crm2.yaml
> new file mode 100644
> index 0000000000..aa90ad15d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/zte,zx279128s-crm2.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/zte,zx279128s-crm2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ZTE ZX279128S CRM2 clock and reset controller
> +
> +maintainers:
> +  - Navid Ghahremani <ghahramani.navid at gmail.com>
> +
> +description:
> +  Top CRM 2 (clock and reset module 2) provides clocks and resets for
> +  PCIe controllers on the ZTE ZX279128S SoC.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: zte,zx279128s-crm2
> +      - items:
> +          - const: zte,zx279128s-crm2
> +          - const: syscon

This is odd. Device is specific, fixed. It either is or is not
compatible, not both.

> +
> +  reg:
> +    maxItems: 1
> +
> +  "#clock-cells":
> +    const: 1

...

> diff --git a/Documentation/devicetree/bindings/clock/zte,zx279128s-topcrm.yaml b/Documentation/devicetree/bindings/clock/zte,zx279128s-topcrm.yaml
> new file mode 100644
> index 0000000000..9466661929
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/zte,zx279128s-topcrm.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/zte,zx279128s-topcrm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ZTE ZX279128S Top Clock and Reset Module
> +
> +maintainers:
> +  - Stefan Dösinger <stefandoesinger at gmail.com>
> +  - Navid Ghahremani <ghahramani.navid at gmail.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The top clock and reset module (CRM) of the ZTE ZX279128S holds the PLLs,
> +  bus clocks, peripheral clocks and the reset controller.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: zte,zx279128s-topcrm
> +      - const: syscon
> +      - const: simple-mfd
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: 25 MHz crystal oscillator
> +
> +  clock-names:
> +    items:
> +      - const: osc
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  '#reset-cells':
> +    const: 1
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 0
> +
> +  reboot:
> +    type: object
> +    $ref: /schemas/power/reset/syscon-reboot.yaml#
> +    description: System reboot controller child node
> +
> +patternProperties:
> +  "^phy@[01]$":

phy-0
phy-1

because your reboot node does not have unit address.

> +    type: object
> +    description: PCIe PHY child nodes

Missing description, compatibles with additionalProperties: true or
full schema with 'false'

So the PHY does not need any resources from the parent? It gets its own
clocks? See explanation of simple-mfd.

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#clock-cells'
> +  - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/zte,zx279128s-crm.h>
> +    #include <dt-bindings/reset/zte,zx279128s-reset.h>
> +
> +    topcrm: clock-controller at 94000000 {
> +        compatible = "zte,zx279128s-topcrm", "syscon", "simple-mfd";
> +        reg = <0x94000000 0x1000>;
> +        clocks = <&osc>;
> +        clock-names = "osc";
> +        #clock-cells = <1>;
> +        #reset-cells = <1>;
> +
> +        reboot {
> +            compatible = "syscon-reboot";
> +            offset = <0x44>;
> +            mask = <0x1>;
> +            value = <0x1>;

Incomplete example.


Best regards,
Krzysztof