[PATCH v3 05/16] ASoC: mediatek: mt8195: Fix main clock error handling
phucduc.bui at gmail.com
phucduc.bui at gmail.com
Wed Oct 14 04:27:40 PDT 2026
From: bui duc phuc <phucduc.bui at gmail.com>
Check the return values of clock enable functions and propagate
errors to the caller.
Disable previously enabled clocks on failure to match the
main clock disable sequence.
Fixes: 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver")
Signed-off-by: bui duc phuc <phucduc.bui at gmail.com>
---
sound/soc/mediatek/mt8195/mt8195-afe-clk.c | 23 +++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-clk.c b/sound/soc/mediatek/mt8195/mt8195-afe-clk.c
index 03d2c4fd1f85..44cddc2b1564 100644
--- a/sound/soc/mediatek/mt8195/mt8195-afe-clk.c
+++ b/sound/soc/mediatek/mt8195/mt8195-afe-clk.c
@@ -716,14 +716,31 @@ static int mt8195_afe_disable_timing_sys(struct mtk_base_afe *afe)
int mt8195_afe_enable_main_clock(struct mtk_base_afe *afe)
{
- mt8195_afe_enable_timing_sys(afe);
+ int ret;
+
+ ret = mt8195_afe_enable_timing_sys(afe);
+ if (ret)
+ return ret;
mt8195_afe_enable_afe_on(afe);
- mt8195_afe_enable_apll_tuner(afe, MT8195_AUD_PLL1);
- mt8195_afe_enable_apll_tuner(afe, MT8195_AUD_PLL2);
+ ret = mt8195_afe_enable_apll_tuner(afe, MT8195_AUD_PLL1);
+ if (ret)
+ goto err_disable_afe_on;
+
+ ret = mt8195_afe_enable_apll_tuner(afe, MT8195_AUD_PLL2);
+ if (ret)
+ goto err_disable_apll1_tuner;
return 0;
+
+err_disable_apll1_tuner:
+ mt8195_afe_disable_apll_tuner(afe, MT8195_AUD_PLL1);
+err_disable_afe_on:
+ mt8195_afe_disable_afe_on(afe);
+ mt8195_afe_disable_timing_sys(afe);
+
+ return ret;
}
int mt8195_afe_disable_main_clock(struct mtk_base_afe *afe)
--
2.43.0
More information about the linux-arm-kernel
mailing list