[PATCH v3 1/6] dmaengine: arm-dma350: Fix source trigger bit

[Frank Li]

On Mon, Oct 12, 2026 at 04:41:50PM +0800, Jelly Jia wrote:
> CH_CTRL_USESRCTRIGIN is the source trigger enable bit in CH_CTRL and
> must use bit 25, not bit 26 which is the destination trigger enable bit
> (CH_CTRL_USEDESTRIGIN).
>
> The constant has no users yet, but enabling the source trigger input
> would silently enable the destination trigger input instead, breaking
> any transfer that waits for a peripheral request. Fix it before the
> first user arrives.
>
> Fixes: 5d099706449d ("dmaengine: Add Arm DMA-350 driver")
> Assisted-by: LLM checkpatch sparse dt_binding_check dtbs_check
> Signed-off-by: Jelly Jia <Jelly.Jia at cixtech.com>
> ---

Reviewed-by: Frank Li <Frank.Li at nxp.com>

>  drivers/dma/arm-dma350.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/arm-dma350.c b/drivers/dma/arm-dma350.c
> index 09403aca8bb0..4e17130de6c8 100644
> --- a/drivers/dma/arm-dma350.c
> +++ b/drivers/dma/arm-dma350.c
> @@ -63,7 +63,7 @@
>
>  #define CH_CTRL			0x0c
>  #define CH_CTRL_USEDESTRIGIN	BIT(26)
> -#define CH_CTRL_USESRCTRIGIN	BIT(26)
> +#define CH_CTRL_USESRCTRIGIN	BIT(25)
>  #define CH_CTRL_DONETYPE	GENMASK(23, 21)
>  #define CH_CTRL_REGRELOADTYPE	GENMASK(20, 18)
>  #define CH_CTRL_XTYPE		GENMASK(11, 9)
> --
> 2.54.0
>