[PATCH v4 2/2] m68k: coldfire: Add RNG support for MCF54418

Greg Ungerer gerg at linux-m68k.org
Mon Oct 12 04:10:29 PDT 2026


Hi JM,

On 12/10/26 18:46, Jean-Michel Hautbois wrote:
> Le 11/10/2026 à 17:28, Greg Ungerer a écrit :
>> On 10/10/26 18:51, Herbert Xu wrote:
>>> On Wed, Aug 19, 2026 at 07:36:36AM +1000, Greg Ungerer wrote:
>>>> On 19/8/26 01:09, Jean-Michel Hautbois wrote:
>>>>> Sorry for the very long silence on this one, it fell off my radar...
>>>>>
>>>>> Le 03/12/2025 à 13:15, Greg Ungerer a écrit :
>>>>>> Hi Jean-Michel,
>>>>>>
>>>>>> On 26/11/25 17:08, Jean-Michel Hautbois via B4 Relay wrote:
>>>>>>> From: Jean-Michel Hautbois <jeanmichel.hautbois at yoseli.org>
>>>>>>>
>>>>>>> Add support for the hardware Random Number Generator (RNGB) found on
>>>>>>> MCF54418 ColdFire processors with clock enabled at platform
>>>>>>> initialization.
>>>>>>>
>>>>>>> The RNGB block is compatible with the imx-rngc driver.
>>>>>>>
>>>>>>> Reviewed-by: Frank Li <Frank.Li at nxp.com>
>>>>>>> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at yoseli.org>
>>>>>>> ---
>>>>>>>    arch/m68k/coldfire/device.c       | 28 ++++++++++++++++++++++++++++
>>>>>>>    arch/m68k/coldfire/m5441x.c       |  2 +-
>>>>>>>    arch/m68k/include/asm/m5441xsim.h |  9 +++++++++
>>>>>>>    drivers/char/hw_random/Kconfig    |  3 ++-
>>>>>>>    drivers/char/hw_random/imx-rngc.c |  7 +++++++
>>>>>>>    5 files changed, 47 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> I am happy with the ColdFire arch parts, so from me:
>>>>>>
>>>>>>       Acked-by: Greg Ungerer <gerg at linux-m68k.org>
>>>>>>
>>>>>> I don't mind taking this commit via the m68knommu git tree if the hw_rng
>>>>>> maintainers are ok with that. Otherwise if you break out the arch/m68k
>>>>>> parts I can apply those on their own.
>>>>>
>>>>> I think Herbert acked ?
>>>>> Do you need another ack ?
>>>>
>>>> I would like to see an acknowledgement that taking this patch via the
>>>> m68knommu git tree (to Linus) is ok with the RNG maintainers.
>>>
>>> I have no objections to this.
>>
>> Thanks Herbert.
>>
>> JM: I have applied this to the for-next branch of the m68knommu git tree.
>> I didn't quite go on cleanly, so please double check it for me.
> 
> Thanks, I think you missed 1/2 ?
> Or did I miss something ?

I assumed patch 1/2 would go via the RNG maintainers directly since it has
no dependency on, and contains no arch code for, m68knommu. Is the expectation
that I should push that too?

Regards
Greg






More information about the linux-arm-kernel mailing list