[PATCH] soc: fsl: cpm1: tsa: fix wrong clocks released on cleanup
Christophe Leroy (CS GROUP)
chleroy at kernel.org
Mon Oct 12 02:50:50 PDT 2026
Le 09/10/2026 à 07:37, Haotian Zhang a écrit :
> tsa_of_parse_tdms() gets and enables tdm->l1tsync_clk and
> tdm->l1tclk_clk in addition to l1rsync_clk and l1rclk_clk, but the
> error cleanup path releases l1rsync_clk/l1rclk_clk again in the
> l1tsync_clk/l1tclk_clk branches. The tsync/tclk clocks are leaked --
> never disabled nor clk_put() -- while rsync/rclk are clk_put() twice,
> underflowing their reference counts. tsa_remove() has the same
> copy-paste bug.
>
> Release the clock actually held in each cleanup branch.
>
> Fixes: 1d4ba0b81c1c ("soc: fsl: cpm1: Add support for TSA")
> Assisted-by: DeepSeek-V4.1-Flash
> Signed-off-by: Haotian Zhang <vulab at iscas.ac.cn>
A similar patch is already in linux-next, discarding this one.
See
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/soc/fsl?id=46201d760c48e771fa2febfcb0787f22c3b71387
More information about the linux-arm-kernel
mailing list