[PATCH v8 08/14] dt-bindings: media: mediatek,vcodec-subdev-decoder: Add MT8196

[Krzysztof Kozlowski]

On Sat, Oct 10, 2026 at 04:36:07PM +0800, Kyrie Wu wrote:
> Compared to previous ICs, the MT8196 supports a 10-bit decoder
> and has a decoding capability of 4K at 120fps. It also supports
> 36-bit DRAM IOVA address and Video Power Control to optimize
> bandwidth and voltage usage.
> 
> Signed-off-by: Kyrie Wu <kyrie.wu at mediatek.com>
> Acked-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> ---
>  .../media/mediatek,vcodec-subdev-decoder.yaml | 49 ++++++++++++++++++-
>  1 file changed, 48 insertions(+), 1 deletion(-)


Honestly, I see random approach your patches visible in how
inconsistently you use subject prefixes.

Where did you describe REASON to drop the tag?


> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> index d1d209cb..d8f25ccd 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> @@ -76,6 +76,7 @@ properties:
>        - mediatek,mt8186-vcodec-dec
>        - mediatek,mt8188-vcodec-dec
>        - mediatek,mt8195-vcodec-dec
> +      - mediatek,mt8196-vcodec-dec
>  
>    reg:
>      minItems: 1
> @@ -96,6 +97,11 @@ properties:
>        The node of system control processor (SCP), using
>        the remoteproc & rpmsg framework.
>  
> +  mediatek,vcp:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: Phandle to the Video Companion Processor (VCP) that runs the
> +      video decoder firmware.
> +
>    "#address-cells":
>      const: 2
>  
> @@ -163,7 +169,6 @@ required:
>    - compatible
>    - reg
>    - iommus
> -  - mediatek,scp
>    - ranges
>  
>  if:
> @@ -179,6 +184,48 @@ then:
>      - interrupts
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mediatek,mt8196-vcodec-dec
> +
> +    then:
> +      required:
> +        - mediatek,vcp
> +
> +      properties:
> +        mediatek,scp: false
> +
> +      patternProperties:
> +        '^video-codec@[0-9a-f]+$':
> +          properties:
> +            compatible:
> +              enum:
> +                - mediatek,mtk-vcodec-core
> +                - mediatek,mtk-vcodec-lat
> +

Missing constraints for clocks

> +            clock-names:
> +              items:
> +                - const: sel
> +                - const: vdec
> +                - const: lat
> +                - const: top

Best regards,
Krzysztof