[PATCH v2 4/6] dt-bindings: dma: arm,dma-350: Document the CIX Sky1 integration
Krzysztof Kozlowski
krzk at kernel.org
Mon Oct 12 01:50:56 PDT 2026
On Fri, Oct 09, 2026 at 01:18:44PM +0800, Jelly Jia wrote:
> The CIX Sky1 DMA-350 integration is the same device with SoC glue around
> it, so it is described by the arm,dma-350 node itself with an additional
> "cix,sky1-dma350" compatible rather than by a separate wrapper node.
>
> Extend the binding with the CIX compatible and the resources the
> integration needs: a clock, a reset, an optional reserved memory region
> used when the controller cannot reach all of system memory, and the
> syscon that routes the channel interrupts to the AP interrupt
> controller on Sky1. The cix,irq-router property is only valid together
> with the CIX compatible.
>
> Assisted-by: LLM checkpatch sparse dt_binding_check dtbs_check
Only LLM. Drop all other tools, which guidance asked you to put here
build process tools?
How is it even possible to assist here with sparse? And really,
mentioning checkpatch is just wrong. EVERY patch must run through
checkpatch, with no exceptions.
Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830
> Signed-off-by: Jelly Jia <Jelly.Jia at cixtech.com>
> ---
> v1 -> v2:
> - Folded the integration into arm,dma-350.yaml: the Sky1 DMA-350 is the
> same device, so it keeps the generic compatible plus a device
> specific "cix,sky1-dma350" compatible, and the integration resources
> are described on the controller node.
> - Dropped the separate cix,sky1-dma350.yaml wrapper binding.
> .../devicetree/bindings/dma/arm,dma-350.yaml | 33 ++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> index 429f682f15d8..3b991985c416 100644
> --- a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> +++ b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> @@ -11,10 +11,23 @@ maintainers:
>
> allOf:
> - $ref: dma-controller.yaml#
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + const: cix,sky1-dma350
> + then:
> + properties:
> + cix,irq-router: false
Entire allOf block goes after required: part.
>
> properties:
> compatible:
> - const: arm,dma-350
> + oneOf:
> + - const: arm,dma-350
> + - items:
> + - const: cix,sky1-dma350
> + - const: arm,dma-350
>
> reg:
> items:
> @@ -36,6 +49,24 @@ properties:
> const: 1
> description: The cell is the trigger input number
>
> + clocks:
> + maxItems: 1
So all devices have clocks and resets?
> +
> + resets:
> + maxItems: 1
> +
> + memory-region:
> + maxItems: 1
and memory-region?
> + description:
> + Reserved memory region used for DMA allocations when the controller
> + cannot reach all of system memory.
> +
> + cix,irq-router:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + Syscon phandle for the CIX Sky1 subsystem register block that routes
> + DMA-350 channel interrupts to the AP interrupt controller.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list