[PATCH v3] dmaengine: qcom: hidma_mgmt: fix autosuspend cleanup on probe failure
Guangshuo Li
lgs201920130244 at gmail.com
Wed Oct 7 05:25:34 PDT 2026
hidma_mgmt_probe() calls pm_runtime_use_autosuspend() during probe, but
the probe failure path does not call the matching
pm_runtime_dont_use_autosuspend() before disabling runtime PM.
Add the missing pm_runtime_dont_use_autosuspend() call to the probe
failure path before pm_runtime_disable() so that the autosuspend
setting is properly undone during cleanup.
This issue was found by manual code inspection.
Fixes: 7f8f209fd6e0 ("dmaengine: add Qualcomm Technologies HIDMA management driver")
Cc: stable at vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244 at gmail.com>
---
v3:
- Add the missing changelog.
v2:
- Keep pm_runtime_enable() and explicitly add the missing
pm_runtime_dont_use_autosuspend() call in the probe failure path
instead of switching to devm_pm_runtime_enable().
- Update the commit message to match the actual change.
drivers/dma/qcom/hidma_mgmt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
index 4805ce390ffa..d8c56af5882d 100644
--- a/drivers/dma/qcom/hidma_mgmt.c
+++ b/drivers/dma/qcom/hidma_mgmt.c
@@ -310,6 +310,7 @@ static int hidma_mgmt_probe(struct platform_device *pdev)
return 0;
out:
pm_runtime_put_sync_suspend(&pdev->dev);
+ pm_runtime_dont_use_autosuspend(&pdev->dev);
pm_runtime_disable(&pdev->dev);
return rc;
}
--
2.43.0
More information about the linux-arm-kernel
mailing list