[PATCH] arm64: dts: rockchip: enable camera on tiger-haikou video-demo adapter

[Quentin Schulz]

Hi Heiko,

On 10/26/26 11:20 AM, Heiko Stuebner wrote:
[...]
> @@ -57,6 +96,23 @@ video-adapter-led {
>   	};
>   };
>   
> +&csi4 {
> +	status = "okay";
> +};
> +
> +&csi4_in {
> +	csi4_input: endpoint {
> +		bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> +		data-lanes = <1 2>;
> +		link-frequencies = /bits/ 64 <450000000>;
> +		remote-endpoint = <&cam_output>;

thought: seems like we are missing link-frequencies and bus-type for 
px30-ringneck-haikou-video-demo.dtso?

> +	};
> +};
> +
> +&csi_dphy1 {
> +	status = "okay";
> +};
> +
>   &dsi0 {
>   	#address-cells = <1>;
>   	#size-cells = <0>;
> @@ -96,6 +152,12 @@ &i2c6 {
>   	#address-cells = <1>;
>   	#size-cells = <0>;
>   
> +	focus: focus at c {
> +		compatible = "dongwoon,dw9714";
> +		reg = <0xc>;
> +		vcc-supply = <&cam_afvdd_2v8>;
> +	};
> +
>   	touchscreen at 14 {
>   		compatible = "goodix,gt911";
>   		reg = <0x14>;
> @@ -118,6 +180,31 @@ pca9670: gpio at 27 {
>   		pinctrl-0 = <&pca9670_resetn>;
>   		reset-gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>;
>   	};
> +
> +	camera at 36 {
> +		compatible = "ovti,ov5675";
> +		reg = <0x36>;
> +		assigned-clocks = <&cru CLK_MIPI_CAMARAOUT_M3>;
> +		assigned-clock-rates = <24000000>;
> +		clocks = <&cru CLK_MIPI_CAMARAOUT_M3>;
> +		avdd-supply = <&cam_avdd_2v8>;
> +		dvdd-supply = <&cam_dvdd_1v2>;
> +		dovdd-supply = <&cam_dovdd_1v8>;
> +		lens-focus = <&focus>;
> +		orientation = <0>;

issue: please use MEDIA_ORIENTATION_FRONT so it's easier to read.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&mipim1_camera3_clk>;
> +		reset-gpios = <&pca9670 6 GPIO_ACTIVE_LOW>;
> +		rotation = <180>;
> +
> +		port {
> +			cam_output: endpoint {

issue: missing bus-type?

I have an additional request to Heiko with the maintainer hat, please 
only merge this once the necessary parts in the OV5675 driver are 
merged. I find it very beneficial that only things that were tested with 
merged commits get enabled/configured in the Device Tree, because I only 
have to check the Device Tree to know if it should be supported on our 
devices, and if it's not then I have some more work to do, and if it is, 
but it doesn't work, I know that it is a regression and I can figure out 
when it got introduced without having to patch the kernel for each 
bisect step.

Tested-by: Quentin Schulz <quentin.schulz at cherry.de>

With the two issues fixed:

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin