[PATCH v5 RESEND 5/6] firmware: smccc: lfa: Register DT interrupt
kernel test robot
lkp at intel.com
Mon Nov 2 23:50:10 PST 2026
Hi Andre,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on arm64/for-next/core linus/master next-20261030]
[cannot apply to arm/for-next arm/fixes clk/clk-next kvmarm/next rockchip/for-next soc/for-next nferre-at91/at91-next shawnguo/for-next v7.3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andre-Przywara/dt-bindings-arm-Add-Live-Firmware-Activation/20261102-175415
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20261102165421.3651202-6-andre.przywara%40arm.com
patch subject: [PATCH v5 RESEND 5/6] firmware: smccc: lfa: Register DT interrupt
config: arm64-randconfig-1000-20261103 (https://download.01.org/0day-ci/archive/20261103/202611031517.aikxJm6o-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261103/202611031517.aikxJm6o-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611031517.aikxJm6o-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/firmware/smccc/lfa_fw.c: In function 'lfa_register_dt':
>> drivers/firmware/smccc/lfa_fw.c:939:16: error: implicit declaration of function 'devm_request_threaded_irq'; did you mean 'devm_request_region'? [-Werror=implicit-function-declaration]
939 | return devm_request_threaded_irq(dev, lfa_irq, NULL,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| devm_request_region
>> drivers/firmware/smccc/lfa_fw.c:940:66: error: 'IRQF_COND_ONESHOT' undeclared (first use in this function)
940 | lfa_irq_handler_thread, IRQF_COND_ONESHOT,
| ^~~~~~~~~~~~~~~~~
drivers/firmware/smccc/lfa_fw.c:940:66: note: each undeclared identifier is reported only once for each function it appears in
drivers/firmware/smccc/lfa_fw.c: In function 'lfa_smccc_remove':
>> drivers/firmware/smccc/lfa_fw.c:1034:9: error: implicit declaration of function 'devm_free_irq'; did you mean 'devm_free_pages'? [-Werror=implicit-function-declaration]
1034 | devm_free_irq(&sdev->dev, lfa_irq, NULL);
| ^~~~~~~~~~~~~
| devm_free_pages
drivers/firmware/smccc/lfa_fw.c: In function 'lfa_register_dt':
drivers/firmware/smccc/lfa_fw.c:942:1: warning: control reaches end of non-void function [-Wreturn-type]
942 | }
| ^
cc1: some warnings being treated as errors
vim +939 drivers/firmware/smccc/lfa_fw.c
925
926 static int lfa_register_dt(struct device *dev)
927 {
928 struct device_node *np;
929
930 np = of_find_compatible_node(NULL, NULL, "arm,lfa");
931 if (!np)
932 return -ENODEV;
933
934 lfa_irq = irq_of_parse_and_map(np, 0);
935 of_node_put(np);
936 if (!lfa_irq)
937 return -ENODEV;
938
> 939 return devm_request_threaded_irq(dev, lfa_irq, NULL,
> 940 lfa_irq_handler_thread, IRQF_COND_ONESHOT,
941 NULL, NULL);
942 }
943
944 static bool lfa_smccc_has_all_functions(void)
945 {
946 struct arm_smccc_1_2_regs regs = { 0 }, res;
947 u32 fn_id;
948
949 regs.a0 = ARM_SMCCC_LFA_FEATURES;
950
951 for (fn_id = ARM_SMCCC_LFA_GET_INFO;
952 fn_id <= ARM_SMCCC_LFA_CANCEL;
953 fn_id++) {
954 regs.a1 = fn_id;
955 arm_smccc_1_2_invoke(®s, &res);
956 if (res.a0)
957 return false;
958 }
959
960 return true;
961 }
962
963 static int lfa_smccc_probe(struct arm_smccc_device *sdev)
964 {
965 struct arm_smccc_1_2_regs regs = { 0 };
966 int err;
967
968 /* The LFA spec requires SMCCC v1.2 or higher. */
969 if (arm_smccc_get_version() < ARM_SMCCC_VERSION_1_2)
970 return -EOPNOTSUPP;
971
972 regs.a0 = ARM_SMCCC_LFA_VERSION;
973 arm_smccc_1_2_invoke(®s, ®s);
974 if ((s32)regs.a0 == LFA_NOT_SUPPORTED)
975 return -ENODEV;
976
977 if (!lfa_smccc_has_all_functions())
978 return -EOPNOTSUPP;
979
980 pr_info("Live Firmware Activation: detected v%d.%d\n",
981 upper_16_bits(regs.a0), lower_16_bits(regs.a0));
982
983 fw_comps_update_wq = alloc_workqueue("fw_comps_update_wq",
984 WQ_UNBOUND | WQ_MEM_RECLAIM, 1);
985 if (!fw_comps_update_wq) {
986 pr_err("Live Firmware Activation: Failed to allocate workqueue.\n");
987 return -ENOMEM;
988 }
989 INIT_WORK(&fw_comps_update_work, remove_invalid_fw_components);
990
991 init_component_default_attrs();
992 lfa_kset = kset_create_and_add("lfa", NULL, firmware_kobj);
993 if (!lfa_kset) {
994 destroy_workqueue(fw_comps_update_wq);
995 return -ENOMEM;
996 }
997
998 init_rwsem(&smc_lock);
999
1000 err = update_fw_components_tree();
1001 if (err != 0) {
1002 kset_unregister(lfa_kset);
1003 destroy_workqueue(fw_comps_update_wq);
1004 return err;
1005 }
1006
1007 if (!acpi_disabled) {
1008 err = lfa_register_acpi(&sdev->dev);
1009 if (!err)
1010 pr_info("registered LFA ACPI notification\n");
1011 } else {
1012 err = lfa_register_dt(&sdev->dev);
1013 if (!err)
1014 pr_info("registered LFA DT notification interrupt\n");
1015 }
1016
1017 /*
1018 * An ACPI notification or an interrupt are optional, but we must
1019 * handle errors that occurred during their setup.
1020 */
1021 if (err != -ENODEV) {
1022 kset_unregister(lfa_kset);
1023 destroy_workqueue(fw_comps_update_wq);
1024 return err;
1025 }
1026
1027 return 0;
1028 }
1029
1030 static void lfa_smccc_remove(struct arm_smccc_device *sdev)
1031 {
1032 if (!acpi_disabled)
1033 lfa_remove_acpi(&sdev->dev);
> 1034 devm_free_irq(&sdev->dev, lfa_irq, NULL);
1035 clean_fw_components_tree();
1036 flush_workqueue(fw_comps_update_wq);
1037 destroy_workqueue(fw_comps_update_wq);
1038 kset_unregister(lfa_kset);
1039 }
1040
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the linux-arm-kernel
mailing list