[PATCH 07/16] media: rkisp1: Power down after subdev initialisation

Daniel Scally dan.scally at ideasonboard.com
Mon Nov 2 23:40:43 PST 2026


We will shortly need to reference the ISP's subdevice in the PM
.runtime_suspend() callback - make sure we don't call it until
after the subdevice has been registered.

Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
---
 drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
index 2efbe6140da71a51077d7d4aa2352ef95497ebe2..9f1d0f72ee9bf4364c696d9fdd8febea80d2bcde 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
@@ -729,11 +729,6 @@ static int rkisp1_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_pm_runtime_disable;
 
-	cif_id = rkisp1_read(rkisp1, RKISP1_CIF_VI_ID);
-	dev_dbg(rkisp1->dev, "CIF_ID 0x%08x\n", cif_id);
-
-	pm_runtime_put(&pdev->dev);
-
 	rkisp1->media_dev.hw_revision = info->isp_ver;
 	strscpy(rkisp1->media_dev.model, RKISP1_DRIVER_NAME,
 		sizeof(rkisp1->media_dev.model));
@@ -770,6 +765,11 @@ static int rkisp1_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unreg_entities;
 
+	cif_id = rkisp1_read(rkisp1, RKISP1_CIF_VI_ID);
+	dev_dbg(rkisp1->dev, "CIF_ID 0x%08x\n", cif_id);
+
+	pm_runtime_put(&pdev->dev);
+
 	rkisp1_debug_init(rkisp1);
 
 	return 0;

-- 
2.43.0




More information about the linux-arm-kernel mailing list