[PATCH 10/16] media: rkisp1: Call .enable_streams() / .disable_streams()

Daniel Scally dan.scally at ideasonboard.com
Mon Nov 2 23:40:46 PST 2026


Call .enable_streams() and .disable_streams() for the ISP and resizer
subdevices instead of the legacy .s_stream(). The subdevices don't
actually support the new operations yet, but v4l2-core will auto
translate them for now.

Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
---
 .../media/platform/rockchip/rkisp1/rkisp1-capture.c    | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
index 757fd35e248a89ff3a6af4e07491239e14dda9c4..fcc6f06437e182c0510fab7df5a50dfe7d0cb48a 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
@@ -1073,10 +1073,11 @@ static void rkisp1_pipeline_stream_disable(struct rkisp1_capture *cap)
 	 * be disabled, skip them.
 	 */
 	if (rkisp1->pipe.start_count < 2)
-		v4l2_subdev_call(&rkisp1->isp.sd, video, s_stream, false);
+		v4l2_subdev_disable_streams(&rkisp1->isp.sd,
+					    RKISP1_ISP_PAD_SOURCE_VIDEO, BIT(0));
 
-	v4l2_subdev_call(&rkisp1->resizer_devs[cap->id].sd, video, s_stream,
-			 false);
+	v4l2_subdev_disable_streams(&rkisp1->resizer_devs[cap->id].sd,
+				    RKISP1_RSZ_PAD_SRC, BIT(0));
 }
 
 /*
@@ -1093,8 +1094,8 @@ static int rkisp1_pipeline_stream_enable(struct rkisp1_capture *cap)
 
 	rkisp1_cap_stream_enable(cap);
 
-	ret = v4l2_subdev_call(&rkisp1->resizer_devs[cap->id].sd, video,
-			       s_stream, true);
+	ret = v4l2_subdev_enable_streams(&rkisp1->resizer_devs[cap->id].sd,
+					 RKISP1_RSZ_PAD_SRC, BIT(0));
 	if (ret)
 		goto err_disable_cap;
 
@@ -1105,15 +1106,16 @@ static int rkisp1_pipeline_stream_enable(struct rkisp1_capture *cap)
 	if (rkisp1->pipe.start_count > 1)
 		return 0;
 
-	ret = v4l2_subdev_call(&rkisp1->isp.sd, video, s_stream, true);
+	ret = v4l2_subdev_enable_streams(&rkisp1->isp.sd,
+					 RKISP1_ISP_PAD_SOURCE_VIDEO, BIT(0));
 	if (ret)
 		goto err_disable_rsz;
 
 	return 0;
 
 err_disable_rsz:
-	v4l2_subdev_call(&rkisp1->resizer_devs[cap->id].sd, video, s_stream,
-			 false);
+	v4l2_subdev_disable_streams(&rkisp1->resizer_devs[cap->id].sd,
+				    RKISP1_RSZ_PAD_SRC, BIT(0));
 err_disable_cap:
 	rkisp1_cap_stream_disable(cap);
 

-- 
2.43.0




More information about the linux-arm-kernel mailing list