[PATCH v2 3/3] can: ifi_canfd: enable NAPI before starting the controller
Patrick Zhang
patrzhan at amazon.com
Mon Nov 2 14:59:45 PST 2026
On Sun, 01 Nov 2026 12:51, netdev-bot+sashiko wrote:
> With NAPI enabled here, can ifi_canfd_poll() now run at the same time as
> the rest of ifi_canfd_start()?
I think the analysis is right, and moving the CAN state and the error
counter writes into ifi_canfd_reset_config() and masking the interrupts
there makes sense. With those changes, the patch reorders the reset,
error counter and interrupt mask writes on both the open and the bus-off
restart paths. At that point the change is no longer obviously correct
by inspection, and I do not have IFI CAN FD hardware to test it, so I
am not confident continuing with it.
I will drop this patch and send v3 with only the ctucanfd and xilinx_can
patches. The race in ifi_canfd_open() remains, and this thread may be a
useful starting point for someone who can test a fix.
pw-bot: cr
More information about the linux-arm-kernel
mailing list